Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[serverless-logic-web-tools] Migrate the devmode image used to deploy workflows to sonataflow-devmode-image #2762

Open
ricardozanini opened this issue Nov 22, 2024 · 0 comments
Assignees

Comments

@ricardozanini
Copy link
Member

Summary

Currently, the Web Tools web application uses a very close image to the sonataflow-devmode-image. We should unify them into one and use the very same on the operator and web tools side.

Goals

  1. Make the SonataFlow Operator Web Tools image to share the same Quarkus Devmode image
  2. Disable the zip upload feature on the Operator side to avoid a security breach

Motivation

We should unify these images since the operator and web tools share the same requirements. One image serving both tools would increase our maintainability and resource use.

Description

The serverless-logic-web-tools-swf-dev-mode-image has a backdoor that the web tools use to update the project files via a ZIP structure. To avoid security breaches, this backdoor must be disabled by default and only enabled by the Web Tools when refreshing the application.

After this work, we can safely remove one of the packages to save build and maintenance resources.

Testing

The exact use case offered today by the web tools and the operator Operator continues to work.

  1. Deploy one workflow with Web Tools, check the running status, and if it creates a workflow instance without any occurrences
  2. Repeat the process with the OperatorOperatortcome must be the same

Risks

Fail to turn off the ZIP backdoor on the Operator deployment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants