Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vscode-extension-serverless-workflow] Diagram Editor displays eventRef: undefined when action references event #2772

Open
domhanak opened this issue Nov 27, 2024 · 3 comments
Assignees

Comments

@domhanak
Copy link
Contributor

Summary

When an eventRef is defined for an action in sonataflow, editor display the reference as undefined when hovering over the icon connected to this. Notably there is some behavior if I use older definitions, probably deprecated syntax now.

Environment

VSCode extension on Linux

Steps to reproduce

  1. Import
    OLD_SYNTAX-event-based-service-invocation.sw.json
  2. Hover over the icon and see Action: eventRef: VetAppointmentInfo AND the file is not syntactically correct as per VSCode syntax checker
  3. Open eventWf.sw.json
  4. Hover over the icon and see Action: eventRef: undefined AND the file is syntactically correct

Actual results

Hover over the icon and see Action: eventRef: undefined

Expected results

Hover over the icon and see Action: eventRef: VetAppointmentInfo
OR
Potentially show both triggerEventRef and resultEventRef for the state.

Testing

Manual verification is sufficient for this case.

@domhanak domhanak changed the title [vscode-extension-serverless-workflow] Editos displays eventRef: undefined when action references event [vscode-extension-serverless-workflow] Editor displays eventRef: undefined when action references event Nov 27, 2024
@fantonangeli
Copy link
Contributor

@domhanak @handreyrc
This is an issue related to the Diagram Editor and can be replicated on Kubesmarts and the other SonataFlow apps as well.
Maybe we can put this bug in "waiting", If we are replacing the Diagram?

@fantonangeli fantonangeli changed the title [vscode-extension-serverless-workflow] Editor displays eventRef: undefined when action references event [vscode-extension-serverless-workflow] Diagram Editor displays eventRef: undefined when action references event Nov 27, 2024
@domhanak
Copy link
Contributor Author

@fantonangeli @handreyrc yea, I reproduced on VSCode, doing it in all of the downstream implementations of swf editor is not possible in reasonable timeframe.
What to do with it is your call. Imho this is not big issue as it only impacts the view.

@fantonangeli
Copy link
Contributor

I reproduced on VSCode, doing it in all of the downstream implementations of swf editor is not possible in reasonable timeframe.

Sure @domhanak , I tested it on Kubesmarts and wrote a note to specify we have this issue on all the SonataFlow implementations ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants