-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KOGITO-9712: Use Patternfly V5 in Dashbuilder #1921
Open
jesuino
wants to merge
15
commits into
apache:main
Choose a base branch
from
jesuino:KOGITO-9712
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
William, thank you so much for this work. Guys, before merging this, let's do a sync up on the impact on the full repo + the broad dependencies (i.e. swf dev UI) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KOGITO-9712: Use Patternfly V5 in Dashbuilder
In this big change we remove the old widgets and the old libraries Bootstrap and Patternfly V3 in favor of Patternfly V5. A few components will be impacted by this change:
The following supported and maintained Dashboards needs to be adjusted:
2.1) The table can use the internal Table to drop the extension component;
2.2) Cards HTML template need to be updated
Finally the Kitchensink example, website and documentation should be updated. This will be done next.
NOTE: There's a memory leak during content refresh. It does not affect runtime, only during edit. The document[2] contains more details;
[1] https://issues.redhat.com/browse/KOGITO-9715
[2] https://docs.google.com/document/d/1UANE7WEQh3YMDygf3X2JAY4XiSlJ_vc8WY6JWh7bsQk/edit