Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KOGITO-9712: Use Patternfly V5 in Dashbuilder #1921

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

jesuino
Copy link
Contributor

@jesuino jesuino commented Aug 17, 2023

KOGITO-9712: Use Patternfly V5 in Dashbuilder

In this big change we remove the old widgets and the old libraries Bootstrap and Patternfly V3 in favor of Patternfly V5. A few components will be impacted by this change:

  1. The Table component order and column picker needs to be updated. Users requiring such feature can rely on the table external component.
  2. Carousel and Slider components needs a new re-design, so it is not re-implemented, but it is not used in any of the samples Dashboards
  3. Navigation buttons in Tabs are missing. This needs to be fixed when GWT UI is completely removed (see [1])

The following supported and maintained Dashboards needs to be adjusted:

  1. Samples needs to be revisited, specially cards templates and HTML using PF3 classes. Cards used icons and classes from PF3;
  2. Serverless Workflow dashboards will work with this change, but when updating the following points need attention:

2.1) The table can use the internal Table to drop the extension component;
2.2) Cards HTML template need to be updated

Finally the Kitchensink example, website and documentation should be updated. This will be done next.

NOTE: There's a memory leak during content refresh. It does not affect runtime, only during edit. The document[2] contains more details;

[1] https://issues.redhat.com/browse/KOGITO-9715
[2] https://docs.google.com/document/d/1UANE7WEQh3YMDygf3X2JAY4XiSlJ_vc8WY6JWh7bsQk/edit

@ederign
Copy link
Member

ederign commented Aug 17, 2023

William, thank you so much for this work.

Guys, before merging this, let's do a sync up on the impact on the full repo + the broad dependencies (i.e. swf dev UI)

@jesuino jesuino temporarily deployed to ci August 22, 2023 01:59 — with GitHub Actions Inactive
@jesuino jesuino temporarily deployed to ci August 22, 2023 01:59 — with GitHub Actions Inactive
@jesuino jesuino temporarily deployed to ci August 23, 2023 02:01 — with GitHub Actions Inactive
@jesuino jesuino temporarily deployed to ci August 23, 2023 02:01 — with GitHub Actions Inactive
@jesuino jesuino temporarily deployed to ci August 23, 2023 16:52 — with GitHub Actions Inactive
@jesuino jesuino temporarily deployed to ci August 23, 2023 16:52 — with GitHub Actions Inactive
@jesuino jesuino temporarily deployed to ci August 23, 2023 21:24 — with GitHub Actions Inactive
@jesuino jesuino temporarily deployed to ci August 23, 2023 21:24 — with GitHub Actions Inactive
@jesuino jesuino temporarily deployed to ci August 23, 2023 21:24 — with GitHub Actions Inactive
@ederign ederign added the pr: DO NOT MERGE Draft PR, not ready for merging label Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:dashbuilder pr: DO NOT MERGE Draft PR, not ready for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants