kie-tools#2497: Set local cluster as default in the sonataflow-dev-ui #2498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjtirado
reviewed
Jul 30, 2024
| @@ -108,14 +108,15 @@ public CardPageBuildItem pages( | |||
|
|
|||
| String openapiPath = getProperty(configurationBuildItem, systemPropertyBuildItems, "quarkus.smallrye-openapi.path"); | |||
| String devUIUrl = getProperty(configurationBuildItem, systemPropertyBuildItems, "kogito.dev-ui.url"); | |||
| String dataIndexUrl = getProperty(configurationBuildItem, systemPropertyBuildItems, "kogito.data-index.url"); | |||
| //String dataIndexUrl = getProperty(configurationBuildItem, systemPropertyBuildItems, "kogito.data-index.url"); | |||
There was a problem hiding this comment.
I think we should remove rather than commenting
fjtirado
reviewed
Jul 30, 2024
| @@ -58,7 +58,8 @@ public SonataFlowQuarkusExtensionJsonRPCService(Vertx vertx) { | |||
|
|
|||
| @PostConstruct | |||
| public void init() { | |||
| isLocalCluster = ConfigProvider.getConfig().getOptionalValue(IS_LOCAL_CLUSTER, Boolean.class).orElse(false); | |||
| //temporary, set isLocalCluster always true since sonataflow-dev-ui works in k8s cluster. | |||
| isLocalCluster = ConfigProvider.getConfig().getOptionalValue(IS_LOCAL_CLUSTER, Boolean.class).orElse(true); | |||
There was a problem hiding this comment.
As commented in a previous PR, I think this should have been done through injection
fjtirado
approved these changes
Jul 30, 2024
tiagobento
changed the title
tiagobento
requested changes
Aug 6, 2024
There was a problem hiding this comment.
@wmedvede Please include the issue link on the description of the PR, or provide a good description at least...
|
Hi! Any updates here? I see some conflicts have built up here too... Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.