kie-issues#2718: [kn-plugin-workflow] Minify the openAPI spec files to trim components/schemas #2749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Path declarations may contain $ref references, which in turn may refer to other declarations. Therefore, before removing them, it is necessary to identify all declarations that the desired operationId depends on. A special case is securitySchemes; if they are present in the document, they should be retained since the reference to them occurs implicitly. |
ricardozanini
approved these changes
Nov 21, 2024
| return nil, fmt.Errorf("❌ ERROR: failed to load OpenAPI document: %w", err) | ||
| } | ||
| if doc.Paths == nil { | ||
| return nil, fmt.Errorf("OpenAPI document %s has no paths", specFileName) |
There was a problem hiding this comment.
Do we want to return an error here? Maybe just log silently to not spur the user's console with an error. If this is handled by the caller, just ignore my comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: #2718