New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] We should use `buffer` method instead `heapBuffer` #2275

Open

2 of 3 tasks

jerqi opened this issue Dec 5, 2024 · 3 comments

Open

2 of 3 tasks

[Improvement] We should use `buffer` method instead `heapBuffer` #2275

jerqi opened this issue Dec 5, 2024 · 3 comments

Contributor

jerqi commented Dec 5, 2024 •

edited

Loading

Code of Conduct

I agree to follow this project's Code of Conduct

Search before asking

I have searched in the issues and found no similar issues.

What would you like to be improved?

Spark code use buffer instead heapBuffer.

How should we improve?

We should use buffer method instead heapBuffer

Are you willing to submit PR?

Yes I am willing to submit a PR!

The text was updated successfully, but these errors were encountered:

Contributor Author

jerqi commented Dec 5, 2024 •

edited

Loading

cc @maobaolong @rickyma

Member

maobaolong commented Dec 6, 2024

I think it should be ByteBuf header = ctx.alloc().directBuffer(headerLength);

Contributor

rickyma commented Dec 6, 2024

We can use DirectBuffer, but we need to release the bytebuf manually.
The length of the header is not large, so it is acceptable to use HeapBuffer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment