[INLONG-11065][Sort] Provides a method to add openTelemetryAppender for the sort connector #11066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or the sort connector
2 tasks
|
Just use it like this： import org.apache.inlong.sort.base.util.OpenTelemetryLogger;
public class XXXSourceReader<T>
{
private static final Logger LOG = LoggerFactory.getLogger(MySqlSourceReader.class);
private final OpenTelemetryLogger openTelemetryLogger;
public XXXSourceReader() {
...
this.openTelemetryLogger = new OpenTelemetryLogger(); // initialize OpenTelemetryLogger
}
@Override
public void start() {
openTelemetryLogger.install(); // install OpenTelemetryLogger
...
}
@Override
public void close() throws Exception {
openTelemetryLogger.uninstall(); // uninstall OpenTelemetryLogger
super.close();
}
...
}And you can configure the opentelemetryAppender by providing some parameters: OpenTelemetryLogger(String serviceName, String endpoint, Layout<?> layout, Level logLevel) |
3 tasks
|
A Demo at #11067 |
vernedeng
reviewed
Sep 20, 2024
...sort/sort-flink/base/src/main/java/org/apache/inlong/sort/base/util/OpenTelemetryLogger.java
Show resolved
Hide resolved
vernedeng
approved these changes
Sep 24, 2024
luchunliang
approved these changes
Sep 24, 2024
wohainilaodou
pushed a commit
to wohainilaodou/inlong
that referenced
this pull request
Oct 8, 2024
…apache#11066) * [INLONG-11065][Sort] Provides a method to add openTelemetryAppender for the sort connector * [INLONG-11065][Sort] Optimize the code format of createOpenTelemetrySdk function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to more conveniently view the log output, using OpenTelemetry to achieve centralized log reporting
Motivation
In order to more conveniently view the sort task log, we need to achieve a centralized log reporting method.
Modifications
inlong-sort/sort-flink/base/pom.xmlandpom.xmlOpenTelemetryLoggerclass to add log reporting functionality for sort-connectorsVerifying this change
(Please pick either of the following options)
This change is a trivial rework/code cleanup without any test coverage.
This change is already covered by existing tests, such as:
(please describe tests)
This change added tests and can be verified as follows:
(example:)
Documentation
The way to integrate OpenTelemetryAppender for connectors that comply with the FLIP-27 standard is as follows: