Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INLONG-11067][Sort] Report mysql-connector logs through openTelemetry #11070

Closed
wants to merge 8 commits into from

Conversation

qy-liuhuo
Copy link
Contributor

Fixes #11067

Motivation

Use openTelemetryLogger(#11066) to report mysql-connector logs to the docker container of opentelemetry-collector

Modifications

  • Change docker-compose.yml to add a opentelemetry-collector container
  • Add the docker/docker-compose/otel-config.yaml file for configure the opentelemetry-collector container
  • Change the inlong-sort/sort-flink/sort-flink-v1.15/sort-connectors/mysql-cdc/src/main/java/org/apache/inlong/sort/mysql/source/reader/MySqlSourceReader.java file to add log reporting function to this connector

Verifying this change

(Please pick either of the following options)

  • This change is a trivial rework/code cleanup without any test coverage.

  • This change is already covered by existing tests, such as:
    (please describe tests)

  • This change added tests and can be verified as follows:

    (example:)

    • Added integration tests for end-to-end deployment with large payloads (10MB)
    • Extended integration test for recovery after broker failure

@aloyszhang
Copy link
Contributor

Please resolve the conflict

qy-liuhuo and others added 2 commits October 9, 2024 19:11
# Conflicts:
#	inlong-sort/sort-flink/base/src/main/java/org/apache/inlong/sort/base/util/OpenTelemetryLogger.java
@qy-liuhuo qy-liuhuo reopened this Oct 9, 2024
# Conflicts:
#	docker/docker-compose/docker-compose.yml
#	inlong-sort/sort-flink/base/src/main/java/org/apache/inlong/sort/base/util/OpenTelemetryLogger.java
@qy-liuhuo
Copy link
Contributor Author

Please resolve the conflict

I have resolved it

@qy-liuhuo
Copy link
Contributor Author

Due to new changes in #11212, this PR is closed and a new implementation will be provided later.

@qy-liuhuo qy-liuhuo removed their assignment Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature][Sort] Report mysql-connector logs through openTelemetry
2 participants