Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature][Sort] Enhanced source metric instrumentation for InLong Sort Flink Connector #11129

Closed
2 tasks done
PeterZh6 opened this issue Sep 16, 2024 · 1 comment · Fixed by #11130
Closed
2 tasks done
Assignees
Milestone

Comments

@PeterZh6
Copy link
Contributor

PeterZh6 commented Sep 16, 2024

Description

Parent Issue: [Feature][Umbrella] Tencent Rhino-bird: Sort metric monitoring and reporting #10961

Description:
This feature focuses on SourceMetric only
This feature introduces enhanced metric instrumentation to improve observability within the InLong Sort Flink Connector, specifically for the Postgres-CDC connector. The newly added metrics in org.apache.inlong.sort.base.metric.SourceExactlyMetriccover deserialization processes, snapshot states, and checkpoint completion.

Key Metric Categories:

  1. Serialization/Deserialization Metrics:

    • Success/Error Counters: Track successful and failed deserialization attempts (numDeserializeSuccess, numDeserializeError).
    • Latency Gauges: Measure the time taken for both serialization and deserialization (deserializeTimeLag, serializeTimeLag).
  2. SnapshotState Metrics:

    • Creation/Error Counters: Monitor the number of snapshots created and errors encountered during snapshot operations (numSnapshotCreate, numSnapshotError).
  3. NotifyComplete Metrics:

    • Completed Snapshots Counter: Track the number of completed checkpoints (numCompletedSnapshots).
    • Snapshot-to-Checkpoint Latency: Record the time between snapshot creation and checkpoint completion (snapshotToCheckpointTimeLag).

Implementation Details:

The metrics are integrated into the Postgres-CDC connector (located in inlong-sort/sort-flink/sort-flink-v1.15/sort-connectors/postgres-cdc) and can be adapted for use in other connectors. Specific changes are made in key methods like deserialize(), snapshotState(), and notifyCheckpointComplete() to gather detailed performance and error data.

This feature enhances monitoring capabilities, providing critical insights into serialization/deserialization performance, checkpoint processes, and other key aspects of the connector's operation.

Use case

No response

Are you willing to submit PR?

  • Yes, I am willing to submit a PR!

Code of Conduct

Copy link

Hello @PeterZh6, thank you for opening your first issue in InLong 🧡 We will respond as soon as possible ⏳
If this is a bug report, please provide screenshots or error logs for us to reproduce your issue, so we can do our best to fix it.
If you have any questions in the meantime, you can also ask us on the InLong Discussions 🔍

@dockerzhang dockerzhang added this to the 1.14.0 milestone Sep 17, 2024
@PeterZh6 PeterZh6 changed the title [Feature][Sort] Enhanced Metric Instrumentation for InLong Sort Flink Connector [Feature][Sort] Enhanced metric Instrumentation for InLong Sort Flink Connector Sep 23, 2024
@PeterZh6 PeterZh6 changed the title [Feature][Sort] Enhanced metric Instrumentation for InLong Sort Flink Connector [Feature][Sort] Enhanced metric instrumentation for InLong Sort Flink Connector Sep 23, 2024
@PeterZh6 PeterZh6 changed the title [Feature][Sort] Enhanced metric instrumentation for InLong Sort Flink Connector [Feature][Sort] Enhanced source metric instrumentation for InLong Sort Flink Connector Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants