From 5560d4f6cfaebdbfa7c083711390a346fba46eec Mon Sep 17 00:00:00 2001
From: wangjunbo <wangjunbo@qiyi.com>
Date: Wed, 10 Apr 2024 17:03:39 +0800
Subject: [PATCH] [KYUUBI #6079] Web UI support Basic authN

---
 kyuubi-server/web-ui/src/App.vue              |  1 +
 .../src/components/login/LoginModal.vue       | 88 ++++++++++++++++++
 .../src/layout/components/header/index.vue    | 91 ++++++++++++++-----
 kyuubi-server/web-ui/src/main.ts              |  5 +-
 kyuubi-server/web-ui/src/pinia/auth/auth.ts   | 42 +++++++++
 kyuubi-server/web-ui/src/utils/request.ts     |  8 ++
 6 files changed, 212 insertions(+), 23 deletions(-)
 create mode 100644 kyuubi-server/web-ui/src/components/login/LoginModal.vue
 create mode 100644 kyuubi-server/web-ui/src/pinia/auth/auth.ts

diff --git a/kyuubi-server/web-ui/src/App.vue b/kyuubi-server/web-ui/src/App.vue
index 76f5f08cd49..5a4eeb9f0e1 100644
--- a/kyuubi-server/web-ui/src/App.vue
+++ b/kyuubi-server/web-ui/src/App.vue
@@ -21,6 +21,7 @@
 </script>
 
 <template>
+  <login-modal />
   <router-view />
 </template>
 
diff --git a/kyuubi-server/web-ui/src/components/login/LoginModal.vue b/kyuubi-server/web-ui/src/components/login/LoginModal.vue
new file mode 100644
index 00000000000..bf89be6ff35
--- /dev/null
+++ b/kyuubi-server/web-ui/src/components/login/LoginModal.vue
@@ -0,0 +1,88 @@
+<template>
+  <el-dialog v-model="dialogVisible" :close-on-click-modal="false" width="600px">
+    <div class="dialog-header">
+      <img class="logo" src="@/assets/images/kyuubi-logo.svg" />
+    </div>
+    <el-form class="login-form">
+      <el-form-item label="Username">
+        <el-input v-model="username" placeholder="Username" />
+      </el-form-item>
+      <el-form-item label="Password">
+        <el-input type="password" v-model="password" placeholder="Password" />
+      </el-form-item>
+      <el-form-item>
+        <p v-if="loginError" class="login-error">{{ loginError }}</p>
+      </el-form-item>
+    </el-form>
+    <div slot="footer" class="dialog-footer">
+      <el-button @click="closeDialog">Cancel</el-button>
+      <el-button type="primary" @click="handleLogin">Login</el-button>
+    </div>
+  </el-dialog>
+</template>
+
+<script setup lang="ts">
+import { ref, onMounted } from 'vue';
+import { useAuthStore } from '@/pinia/auth/auth';
+
+const authStore = useAuthStore();
+const dialogVisible = ref(false);
+const username = ref('');
+const password = ref('');
+const loginError = ref('');
+
+const handleLogin = async () => {
+  try {
+    await authStore.setUser(username.value, password.value);
+    dialogVisible.value = false;
+    loginError.value = '';
+  } catch (error) {
+    loginError.value = (error as Error).message;
+  }
+};
+
+const closeDialog = () => {
+  dialogVisible.value = false;
+  loginError.value = '';
+};
+
+onMounted(() => {
+  window.addEventListener('auth-required', () => {
+    dialogVisible.value = true;
+  });
+});
+</script>
+
+<style scoped>
+.dialog-header {
+  display: flex;
+  flex-direction: column;
+  align-items: center;
+  margin-bottom: 20px;
+}
+
+.logo {
+  width: 80px;
+  height: auto;
+  margin-bottom: 10px;
+}
+
+.login-form {
+  margin-bottom: 20px;
+}
+
+.login-error {
+  color: red;
+  margin-top: 10px;
+  text-align: center;
+}
+
+.dialog-footer {
+  text-align: right;
+  padding: 15px 20px;
+
+  &>button:not(:last-child) {
+    margin-right: 10px;
+  }
+}
+</style>
diff --git a/kyuubi-server/web-ui/src/layout/components/header/index.vue b/kyuubi-server/web-ui/src/layout/components/header/index.vue
index ada2a860543..57a128ff7fb 100644
--- a/kyuubi-server/web-ui/src/layout/components/header/index.vue
+++ b/kyuubi-server/web-ui/src/layout/components/header/index.vue
@@ -18,27 +18,44 @@
 
 <template>
   <div class="header-container">
-    <el-icon :size="20" @click="_changeCollapse">
-      <component :is="isCollapse ? 'Expand' : 'Fold'" />
-    </el-icon>
-    <el-dropdown @command="handleClick">
-      <span class="el-dropdown-link">
-        {{ currentLocale }}
-        <el-icon class="el-icon--right">
-          <arrow-down />
-        </el-icon>
-      </span>
-      <template #dropdown>
-        <el-dropdown-menu>
-          <el-dropdown-item
-            v-for="(locale, key) in locales"
-            :key="key"
-            :command="locale.key">
-            {{ locale.label }}
-          </el-dropdown-item>
-        </el-dropdown-menu>
+    <div class="left-container">
+      <el-icon :size="20" @click="_changeCollapse">
+        <component :is="isCollapse ? 'Expand' : 'Fold'" />
+      </el-icon>
+    </div>
+    <div class="right-container">
+      <template v-if="authStore.isAuthenticated">
+        <el-dropdown>
+          <span class="el-dropdown-link">
+            {{ authStore.user }}
+            <el-icon class="el-icon--right">
+              <arrow-down />
+            </el-icon>
+          </span>
+          <template #dropdown>
+            <el-dropdown-menu>
+              <el-dropdown-item @click.native="handleLogout">Sign out</el-dropdown-item>
+            </el-dropdown-menu>
+          </template>
+        </el-dropdown>
       </template>
-    </el-dropdown>
+      <el-button v-else @click="showLoginModal">Sign in</el-button>
+      <el-dropdown @command="handleClick">
+        <span class="el-dropdown-link">
+          {{ currentLocale }}
+          <el-icon class="el-icon--right">
+            <arrow-down />
+          </el-icon>
+        </span>
+        <template #dropdown>
+          <el-dropdown-menu>
+            <el-dropdown-item v-for="(locale, key) in locales" :key="key" :command="locale.key">
+              {{ locale.label }}
+            </el-dropdown-item>
+          </el-dropdown-menu>
+        </template>
+      </el-dropdown>
+    </div>
   </div>
 </template>
 
@@ -48,12 +65,16 @@
   import { useLocales } from './use-locales'
   import { LOCALES } from './types'
   import { reactive } from 'vue'
+  import { ref, onUnmounted } from 'vue';
+  import { useAuthStore } from '@/pinia/auth/auth';
+  import LoginModal from '@/login/LoginModal.vue';
 
   const locales = reactive(LOCALES)
   const { changeLocale, currentLocale } = useLocales()
   const store = useStore()
   const { isCollapse } = storeToRefs(store)
   const { changeCollapse } = store
+  
 
   function _changeCollapse() {
     changeCollapse()
@@ -62,6 +83,18 @@
   function handleClick(command: string) {
     changeLocale(command)
   }
+
+  const authStore = useAuthStore();
+  const handleLogout = (command: string) => {
+      logout(); 
+  };
+  const logout = () => {
+    authStore.clearUser();
+  };
+
+  const showLoginModal = () => {
+    window.dispatchEvent(new CustomEvent('auth-required'));
+  };
 </script>
 
 <style lang="scss" scoped>
@@ -69,13 +102,27 @@
     display: flex;
     justify-content: space-between;
     width: 100%;
+  }
 
-    > .el-icon {
+  .left-container {
+    >.el-icon {
       padding: 0 24px;
       cursor: pointer;
+      position: relative;
+      top: 2px;
     }
+  }
+
+  .right-container {
+    display: flex;
+    align-items: center;
 
-    > .el-dropdown .el-icon {
+    >*:not(:last-child) {
+      margin-right: 16px; 
+    }
+    
+    >.el-dropdown .el-icon,
+    >.el-button {
       position: relative;
       top: 2px;
     }
diff --git a/kyuubi-server/web-ui/src/main.ts b/kyuubi-server/web-ui/src/main.ts
index 7e7d4d354b8..c0c71a9c5fe 100644
--- a/kyuubi-server/web-ui/src/main.ts
+++ b/kyuubi-server/web-ui/src/main.ts
@@ -24,9 +24,12 @@ import '@/assets/styles/element/index.scss'
 import '@/assets/styles/index.scss'
 import App from './App.vue'
 import * as ElementPlusIconsVue from '@element-plus/icons-vue'
+import LoginModal from '@/components/login/LoginModal.vue'
+import piniaPluginPersistedstate from 'pinia-plugin-persistedstate';
 
 const app = createApp(App)
 for (const [key, component] of Object.entries(ElementPlusIconsVue)) {
   app.component(key, component)
 }
-app.use(router).use(store).use(i18n).use(ElementPlus).mount('#app')
+store.use(piniaPluginPersistedstate);
+app.component('LoginModal',LoginModal).use(router).use(store).use(i18n).use(ElementPlus).mount('#app')
diff --git a/kyuubi-server/web-ui/src/pinia/auth/auth.ts b/kyuubi-server/web-ui/src/pinia/auth/auth.ts
new file mode 100644
index 00000000000..78ee0237638
--- /dev/null
+++ b/kyuubi-server/web-ui/src/pinia/auth/auth.ts
@@ -0,0 +1,42 @@
+import { defineStore } from 'pinia';
+import request from '@/utils/request';
+
+export const useAuthStore = defineStore('auth', {
+  state: () => ({
+    user: null as string | null,
+    authToken: null as string | null,
+    isAuthenticated: false,
+  }),
+  actions: {
+    async setUser(user: string, password: string) {
+      try {
+        const response = await request({
+          url: 'api/v1/ping',
+          method: 'get',
+          auth: {
+            username: user,
+            password: password,
+          },
+        });
+
+        if (response) {
+          this.user = user;
+          this.authToken = `Basic ${btoa(user + ':' + password)}`;
+          this.isAuthenticated = true;
+        } else {
+          throw new Error('Authentication failed');
+        }
+      } catch (error) {
+        throw error;
+      }
+    },
+    clearUser() {
+      this.user = null;
+      this.authToken = null;
+      this.isAuthenticated = false;
+    },
+  },
+  persist: {
+    key: 'auth',
+  },
+});
\ No newline at end of file
diff --git a/kyuubi-server/web-ui/src/utils/request.ts b/kyuubi-server/web-ui/src/utils/request.ts
index 6171ed9cd99..c0a8d7b9c41 100644
--- a/kyuubi-server/web-ui/src/utils/request.ts
+++ b/kyuubi-server/web-ui/src/utils/request.ts
@@ -16,6 +16,7 @@
  */
 
 import axios, { AxiosResponse } from 'axios'
+import { useAuthStore } from '@/pinia/auth/auth';
 
 // create an axios instance
 const service = axios.create({
@@ -28,6 +29,10 @@ const service = axios.create({
 service.interceptors.request.use(
   (config) => {
     // do something before request is sent
+    const authStore = useAuthStore();
+    if (authStore.isAuthenticated) {
+      config.headers.Authorization = authStore.authToken;
+    }
     return config
   },
   (error) => {
@@ -56,6 +61,9 @@ service.interceptors.response.use(
   (error) => {
     // for debug
     // do something when error
+    if (error.response && error.response.status === 401) {
+      window.dispatchEvent(new CustomEvent('auth-required'));
+    }
     return Promise.reject(error)
   }
 )