From 5df34e42cb7753d34b1701c57c9113911febef7a Mon Sep 17 00:00:00 2001 From: Cheng Pan Date: Thu, 7 Mar 2024 15:31:00 +0800 Subject: [PATCH] [KYUUBI #5509][FOLLOWUP] JDBC IT should always depends on kyuubi-hive-jdbc-shaded MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit # :mag: Description ## Issue References ๐Ÿ”— `build/dist` is going to fail without profile `-Pjdbc-shaded` after bumping a new version. ## Describe Your Solution ๐Ÿ”ง Making the JDBC IT module always depends on `kyuubi-hive-jdbc-shaded`, to ensure the shaded JDBC is packaged before the JDBC IT module performs copy jars. ## Types of changes :bookmark: - [x] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Test Plan ๐Ÿงช Bump a new version, then perform making the distribution. ``` build/mvn versions:set -DgenerateBackupPoms=false -DnewVersion="1.9.1-SNAPSHOT" build/dist --spark-provided --hive-provided --flink-provided ``` Before, failed with ``` [ERROR] Failed to execute goal org.apache.maven.plugins:maven-dependency-plugin:3.6.1:copy (copy) on project kyuubi-jdbc-it_2.12: Unable to find/resolve artifact.: Could not find artifact org.apache.kyuubi:kyuubi-hive-jdbc-shaded:jar:1.9.1-SNAPSHOT in aliyun-apache-snapshots (https://maven.aliyun.com/repository/apache-snapshots/) -> [Help 1] ``` After, everything goes well. --- # Checklist ๐Ÿ“ - [x] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) **Be nice. Be informative.** Closes #6135 from pan3793/impala-folowup. Closes #5509 12f600d2d [Cheng Pan] [KYUUBI #5509][FOLLOWUP] JDBC IT should always depends on kyuubi-hive-jdbc-shaded Authored-by: Cheng Pan Signed-off-by: Cheng Pan --- integration-tests/kyuubi-jdbc-it/pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/integration-tests/kyuubi-jdbc-it/pom.xml b/integration-tests/kyuubi-jdbc-it/pom.xml index 5b4edbcbd62..ee9143540f2 100644 --- a/integration-tests/kyuubi-jdbc-it/pom.xml +++ b/integration-tests/kyuubi-jdbc-it/pom.xml @@ -68,7 +68,7 @@ org.apache.kyuubi - ${hive.jdbc.artifact} + kyuubi-hive-jdbc-shaded ${project.version} test