From e3bda5f155d4b7dab879ecb6cadfa8540555bdca Mon Sep 17 00:00:00 2001 From: Bowen Liang Date: Sat, 16 Dec 2023 08:35:35 +0800 Subject: [PATCH] update --- .../kyuubi/engine/jdbc/mysql/WithMySQLEngine.scala | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/externals/kyuubi-jdbc-engine/src/test/scala/org/apache/kyuubi/engine/jdbc/mysql/WithMySQLEngine.scala b/externals/kyuubi-jdbc-engine/src/test/scala/org/apache/kyuubi/engine/jdbc/mysql/WithMySQLEngine.scala index bd79e0a27b6..db4549fc07a 100644 --- a/externals/kyuubi-jdbc-engine/src/test/scala/org/apache/kyuubi/engine/jdbc/mysql/WithMySQLEngine.scala +++ b/externals/kyuubi-jdbc-engine/src/test/scala/org/apache/kyuubi/engine/jdbc/mysql/WithMySQLEngine.scala @@ -25,10 +25,8 @@ import org.apache.kyuubi.engine.jdbc.WithJdbcEngine trait WithMySQLEngine extends WithJdbcEngine with TestContainerForAll { - private val mysqlDockerImage = "mysql:8.0.32" - override val containerDef = MySQLContainer.Def( - dockerImageName = DockerImageName.parse(mysqlDockerImage), + dockerImageName = DockerImageName.parse("mysql:8.0.32"), username = "root", password = "kyuubi") @@ -36,10 +34,10 @@ trait WithMySQLEngine extends WithJdbcEngine with TestContainerForAll { Map( ENGINE_SHARE_LEVEL.key -> "SERVER", ENGINE_JDBC_CONNECTION_URL.key -> mysqlContainer.jdbcUrl, - ENGINE_JDBC_CONNECTION_USER.key -> "root", - ENGINE_JDBC_CONNECTION_PASSWORD.key -> "kyuubi", + ENGINE_JDBC_CONNECTION_USER.key -> mysqlContainer.username, + ENGINE_JDBC_CONNECTION_PASSWORD.key -> mysqlContainer.password, ENGINE_TYPE.key -> "jdbc", ENGINE_JDBC_SHORT_NAME.key -> "mysql", - ENGINE_JDBC_DRIVER_CLASS.key -> "com.mysql.cj.jdbc.Driver") + ENGINE_JDBC_DRIVER_CLASS.key -> mysqlContainer.driverClassName) } }