Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TASK][TRIVIAL] Remove Spark 3.0 support for Authz #5362

Closed
5 of 8 tasks
AngersZhuuuu opened this issue Oct 8, 2023 · 0 comments
Closed
5 of 8 tasks

[TASK][TRIVIAL] Remove Spark 3.0 support for Authz #5362

AngersZhuuuu opened this issue Oct 8, 2023 · 0 comments
Assignees
@AngersZhuuuu
Labels
hacktoberfest hacktoberfest-accepted

Comments

@AngersZhuuuu
Copy link
Contributor

Code of Conduct

Search before asking

  • I have searched in the issues and found no similar issues.

What kind of test improve?

  • Fix flaky tests.
  • Fix bug in tests.
  • Increase test coverage.
  • Other kinds of test improve.

Describe the issues of the existing tests or improvements for new tests

Remove test Kyuubi-AuthZ and Spark Test for spark 3.0.3

Are you willing to submit PR?

  • Yes. I would be willing to submit a PR with guidance from the Kyuubi community to improve.
  • No. I cannot submit a PR at this time.
@bowenliang123 bowenliang123 mentioned this issue Oct 10, 2023
Closed
3 tasks
@pan3793 pan3793 changed the title [TEST] Remove unencessary test for spark 3.0.3 [TASK][TRIVIAL] Remove Spark 3.0 support for Authz Oct 10, 2023
@bowenliang123 bowenliang123 mentioned this issue Oct 11, 2023
Closed
3 tasks
bowenliang123 added a commit that referenced this issue Oct 12, 2023
@bowenliang123
[KYUUBI #5399] [AUTHZ] Cleanup Spark 3.0 specific implementation
98b74d2 
### _Why are the changes needed?_

The cleanup follow-up for #5362, which removed the Spark 3.0 tests for Authz plugin.
Remove the `isSpark31OrGreater` and Spark 3.0 specific implementations in Authz plugin.

### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

- [ ] Add screenshots for manual tests if appropriate

- [x] [Run test](https://kyuubi.readthedocs.io/en/master/contributing/code/testing.html#running-tests) locally before make a pull request

### _Was this patch authored or co-authored using generative AI tooling?_

No.

Closes #5399 from bowenliang123/authz-31greater.

Closes #5399

db4369b [Bowen Liang] import
cc38b1c [Bowen Liang] fix MASK_SHOW_FIRST_4
cf3ef4e [Bowen Liang] remove isSparkV31OrGreater

Authored-by: Bowen Liang <[email protected]>
Signed-off-by: Bowen Liang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AngersZhuuuu AngersZhuuuu

Labels
hacktoberfest hacktoberfest-accepted
Projects
No open projects
2023 Kyuubi Code Contribution Program
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[KYUUBI #5362] Remove Spark 3.0 support for Authz AngersZhuuuu/incubator-kyuubi
2 participants
@pan3793 @AngersZhuuuu