Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TASK][MEDIUM] JDBC Engine supports ClickHouse #5374

Closed
2 of 3 tasks
pan3793 opened this issue Oct 8, 2023 · 7 comments
Closed
2 of 3 tasks

[TASK][MEDIUM] JDBC Engine supports ClickHouse #5374

pan3793 opened this issue Oct 8, 2023 · 7 comments
Assignees
@lsm1
Labels
hacktoberfest

Comments

@pan3793
Copy link
Member

pan3793 commented Oct 8, 2023

Code of Conduct

Search before creating

  • I have searched in the task list and found no similar tasks.

Mentor

  • I have sufficient knowledge and experience of this task, and I volunteer to be the mentor of this task to guide contributors to complete the task.

Skill requirements

  • Basic knowledge of Scala programming language
  • Basic knowledge of JDBC concepts
  • Basic knowledge of Docker and Testcontianers

Background and Goals

Currently, Kyuubi supports JDBC engines with limited dialects, e.g. Doris, Phoenix, we can easily extend the dialects to support more databases.

Reference https://www.bilibili.com/video/BV1UT411m7LR

Implementation steps

  • Implement a ClickHouse dialect in the JDBC engine
  • Leverage the Testcontainers to add integration tests
  • Update document correspondingly

Additional context

No response
@merrily01
Copy link
Contributor

May i take this please ?

@pan3793
Copy link
Member Author

pan3793 commented Oct 10, 2023

Sure, could please

... leave a comment with a reasonable estimated deadline

@merrily01
Copy link
Contributor

Sure, could please

... leave a comment with a reasonable estimated deadline

I'm not very familiar with CK, but would like to try it, maybe for a month，thanks~

@pan3793
Copy link
Member Author

pan3793 commented Oct 10, 2023

Support other popular DB is fine too, feel free to make PRs, all your contribution will be counted :)

@cekicbaris
Copy link

hey guys, any progress on this ?

@pan3793
Copy link
Member Author

pan3793 commented Mar 24, 2024

@cekicbaris there is a draft PR #5644, as the original author has no response, you can take over it if you like

@lsm1
Copy link
Contributor

lsm1 commented Mar 27, 2024

I have interest in it, May i take this please ?

@lsm1 lsm1 mentioned this issue Mar 28, 2024
Closed
4 tasks
@pan3793 pan3793 changed the title [TASK][EASY] JDBC Engine supports ClickHouse [TASK][MEDIUM] JDBC Engine supports ClickHouse Apr 2, 2024
@pan3793 pan3793 closed this as completed in 03c3b4d Apr 2, 2024
pan3793 pushed a commit that referenced this issue Apr 7, 2024
@lsm1 @pan3793
[KYUUBI #5374][FOLLOWUP] Fix JDBC ClickHouse TRowSet Generator
10e3dec 
# 🔍 Description
## Issue References 🔗

## Describe Your Solution 🔧
Some data type like `UInt8` in ck can not cast to `short`,  we should fix it

## Types of changes 🔖

- [x] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)

## Test Plan 🧪

#### Behavior Without This Pull Request ⚰️

#### Behavior With This Pull Request 🎉

#### Related Unit Tests

---

# Checklist 📝

- [ ] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html)

**Be nice. Be informative.**

Closes #6270 from lsm1/branch-fix-jdbc-ck-short.

Closes #5374

b5dac0f [senmiaoliu] ck fix RowSetGenerator

Authored-by: senmiaoliu <[email protected]>
Signed-off-by: Cheng Pan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lsm1 lsm1

Labels
hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[KYUUBI #5374] JDBC Engine supports ClickHouse lsm1/kyuubi
4 participants
@merrily01 @lsm1 @pan3793 @cekicbaris