Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] Introduce Prometheus and Grafana for Kyuubi Playground #5944

Closed
3 of 4 tasks
zwangsheng opened this issue Jan 4, 2024 · 0 comments
Closed
3 of 4 tasks

Comments

@zwangsheng
Copy link
Contributor

Code of Conduct

Search before asking

  • I have searched in the issues and found no similar issues.

What would you like to be improved?

Improve Kyuubi playground module, help developer to build kyuubi dashboard.

How should we improve?

No response

Are you willing to submit PR?

  • Yes. I would be willing to submit a PR with guidance from the Kyuubi community to improve.
  • No. I cannot submit a PR at this time.
zhaohehuhu pushed a commit to zhaohehuhu/incubator-kyuubi that referenced this issue Feb 5, 2024
…ground

# 🔍 Description
## Issue References 🔗

This pull request fixes apache#5944

## Describe Your Solution 🔧

Add prometheus and grafana docker image to docker compose yaml, and by defaults, prometheus will get kyuubi server's metrics and grafana set prometheus as default datasource.

Help developers quickly build a dashboard development environment.

## Types of changes 🔖

- [ ] Bugfix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)

## Test Plan 🧪

In local test
- [x] all container start success
- [x] By defaults, prometheus get kyuubi's metrics
- [x] Grafana take the prometheus as default  datasource

#### Behavior Without This Pull Request ⚰️

#### Behavior With This Pull Request 🎉

#### Related Unit Tests

---

# Checklist 📝

- [x] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html)

**Be nice. Be informative.**

Closes apache#5945 from zwangsheng/KYUUBI#5944.

Closes apache#5944

031deed [Binjie Yang] Update docker/playground/README.md
dbf41e3 [zwangsheng] declare metrics related config
e6efe30 [zwangsheng] make grafana as anonymous
404dd42 [zwangsheng] fix comments
f7ca4ae [zwangsheng] fix prometheus
089f8d0 [zwangsheng] eof
6872078 [zwangsheng] add license header
cfa6edf [zwangsheng] [KYUUBI apache#5944][Improvement] Introduce Prometheus and Grafana for Kyuubi Playground

Lead-authored-by: zwangsheng <[email protected]>
Co-authored-by: Binjie Yang <[email protected]>
Signed-off-by: Cheng Pan <[email protected]>
zhaohehuhu pushed a commit to zhaohehuhu/incubator-kyuubi that referenced this issue Mar 21, 2024
…ground

# 🔍 Description
## Issue References 🔗

This pull request fixes apache#5944

## Describe Your Solution 🔧

Add prometheus and grafana docker image to docker compose yaml, and by defaults, prometheus will get kyuubi server's metrics and grafana set prometheus as default datasource.

Help developers quickly build a dashboard development environment.

## Types of changes 🔖

- [ ] Bugfix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)

## Test Plan 🧪

In local test
- [x] all container start success
- [x] By defaults, prometheus get kyuubi's metrics
- [x] Grafana take the prometheus as default  datasource

#### Behavior Without This Pull Request ⚰️

#### Behavior With This Pull Request 🎉

#### Related Unit Tests

---

# Checklist 📝

- [x] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html)

**Be nice. Be informative.**

Closes apache#5945 from zwangsheng/KYUUBI#5944.

Closes apache#5944

031deed [Binjie Yang] Update docker/playground/README.md
dbf41e3 [zwangsheng] declare metrics related config
e6efe30 [zwangsheng] make grafana as anonymous
404dd42 [zwangsheng] fix comments
f7ca4ae [zwangsheng] fix prometheus
089f8d0 [zwangsheng] eof
6872078 [zwangsheng] add license header
cfa6edf [zwangsheng] [KYUUBI apache#5944][Improvement] Introduce Prometheus and Grafana for Kyuubi Playground

Lead-authored-by: zwangsheng <[email protected]>
Co-authored-by: Binjie Yang <[email protected]>
Signed-off-by: Cheng Pan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant