Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] Performance Improvement for converting spark rows to thrift rows #6070

Closed
3 of 4 tasks
yaooqinn opened this issue Feb 22, 2024 · 2 comments
Closed
3 of 4 tasks

[Improvement] Performance Improvement for converting spark rows to thrift rows #6070

yaooqinn opened this issue Feb 22, 2024 · 2 comments
Assignees
@beryllw
Labels
good first issue beginner skills required help wanted
Milestone
v1.9.0

Comments

@yaooqinn
Copy link
Member

Code of Conduct

Search before asking

  • I have searched in the issues and found no similar issues.

What would you like to be improved?

https://issues.apache.org/jira/browse/SPARK-47085 reported an issue, scala Seq.apply has O(n) complexity so that we shall avoid it

How should we improve?

No response

Are you willing to submit PR?

  • Yes. I would be willing to submit a PR with guidance from the Kyuubi community to improve.
  • No. I cannot submit a PR at this time.
@yaooqinn yaooqinn added help wanted good first issue beginner skills required labels Feb 22, 2024
@yaooqinn yaooqinn added this to the v1.9.0 milestone Feb 22, 2024
@beryllw
Copy link
Contributor

beryllw commented Feb 22, 2024

Please assgin to me, thanks.

@yaooqinn
Copy link
Member Author

thank you @Kwafoor

beryllw pushed a commit to beryllw/incubator-kyuubi that referenced this issue Feb 22, 2024
[KYUUBI apache#6070] Performance Improvement for converting rows to t…
5442296 
…hrift rows
@beryllw beryllw mentioned this issue Feb 22, 2024
Closed
4 tasks
zhaohehuhu pushed a commit to zhaohehuhu/incubator-kyuubi that referenced this issue Mar 21, 2024
@zhaohehuhu
[KYUUBI apache#6070] Improve perf on assembling row-based TRowSet
ef2c754 
# 🔍 Description
## Issue References 🔗

This pull request fixes apache#6070

## Describe Your Solution 🔧

https://issues.apache.org/jira/browse/SPARK-47085

## Types of changes 🔖

- [ ] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)

## Test Plan 🧪

#### Behavior Without This Pull Request ⚰️

#### Behavior With This Pull Request 🎉

#### Related Unit Tests

---

# Checklist 📝

- [ ] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html)

**Be nice. Be informative.**

Closes apache#6077 from Kwafoor/kyuubi_6070.

Closes apache#6070

84114f3 [wangjunbo] fix
90a1256 [wangjunbo] fix
97db3c9 [wangjunbo] fix
5442296 [wangjunbo] [KYUUBI apache#6070] Performance Improvement for converting rows to thrift rows

Authored-by: wangjunbo <[email protected]>
Signed-off-by: Cheng Pan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@beryllw beryllw

Labels
good first issue beginner skills required help wanted
Projects
None yet
Milestone
v1.9.0
Development

Successfully merging a pull request may close this issue.

[KYUUBI #6070] Improve perf on assembling row-based TRowSet beryllw/incubator-kyuubi
2 participants
@yaooqinn @beryllw