Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TASK][MEDIUM] Web UI support Basic authN #6079

Closed
3 of 4 tasks
beryllw opened this issue Feb 23, 2024 · 5 comments
Closed
3 of 4 tasks

[TASK][MEDIUM] Web UI support Basic authN #6079

beryllw opened this issue Feb 23, 2024 · 5 comments
Assignees
@beryllw

Comments

@beryllw
Copy link
Contributor

beryllw commented Feb 23, 2024 •
edited by pan3793
Loading

Code of Conduct

Search before asking

  • I have searched in the issues and found no similar issues.

What would you like to be improved?

#6042 (comment)

How should we improve?

Support Basic authN for Web UI - that means, when SASL/Plain(LDAP/JDBC/CUSTOM) auth method is configured, pop something like below to allow user login via username and password

image

Are you willing to submit PR?

  • Yes. I would be willing to submit a PR with guidance from the Kyuubi community to improve.
  • No. I cannot submit a PR at this time.
@zwangsheng
Copy link
Contributor

Hi @Kwafoor, any progress here?

@beryllw
Copy link
Contributor Author

beryllw commented Mar 5, 2024

Hi @Kwafoor, any progress here?

Still in progress.It may take a week.

@pan3793 pan3793 changed the title [Improvement] Web UI support basic authN [TASK][EASY] Web UI support Basic authN Apr 3, 2024
@pan3793
Copy link
Member

pan3793 commented Apr 3, 2024 •
edited
Loading

Promoted this to a contribution program task, classify it to EASY level temporarily, and we can re-evaluate the level after completing by the real work.

@beryllw please let me know if you still want to take this task

@beryllw
Copy link
Contributor Author

beryllw commented Apr 4, 2024

@beryllw please let me know if you still want to take this task

yes, i will do it soon.

@beryllw beryllw mentioned this issue Apr 4, 2024
Closed
4 tasks
@pan3793 pan3793 changed the title [TASK][EASY] Web UI support Basic authN [TASK][MEDIUM] Web UI support Basic authN Apr 9, 2024
@pan3793
Copy link
Member

pan3793 commented Apr 9, 2024

The task takes more effort than I thought initially, escalating the task level from easy to medium.

beryllw pushed a commit to beryllw/incubator-kyuubi that referenced this issue Apr 10, 2024
[KYUUBI apache#6079] Web UI support Basic authN
5560d4f
beryllw pushed a commit to beryllw/incubator-kyuubi that referenced this issue Apr 10, 2024
[KYUUBI apache#6079] Web UI support Basic authN
97772e5
beryllw pushed a commit to beryllw/incubator-kyuubi that referenced this issue Apr 10, 2024
[KYUUBI apache#6079] Web UI support Basic authN
788bdfa
pan3793 pushed a commit that referenced this issue Apr 11, 2024
@pan3793
[KYUUBI #6079] Web UI support Basic authN
8b4a649 
# 🔍 Description
## Issue References 🔗

This pull request fixes #6079

## Describe Your Solution 🔧

<img width="1160" alt="image" src="https://github.com/apache/kyuubi/assets/25627922/eef26a0e-478a-4e65-a0a4-629e0afa9a52">

![zpHy0SGauD](https://github.com/apache/kyuubi/assets/25627922/176d4436-509b-406a-984b-8eb0dab9698e)

![image](https://github.com/apache/kyuubi/assets/25627922/3d637718-b177-48b2-bd6a-9ec8065b8b9c)

## Types of changes 🔖

- [ ] Bugfix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)

## Test Plan 🧪

---

# Checklist 📝

- [ ] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html)

**Be nice. Be informative.**

Closes #6258 from beryllw/kyuubi-6079.

Closes #6079

7a90286 [wangjunbo] support input valid
6e2093e [wangjunbo] format code
a781c0a [wangjunbo] add License
788bdfa [wangjunbo] [KYUUBI #6079] Web UI support Basic authN
97772e5 [wangjunbo] [KYUUBI #6079] Web UI support Basic authN
5560d4f [wangjunbo] [KYUUBI #6079] Web UI support Basic authN

Authored-by: wangjunbo <[email protected]>
Signed-off-by: Cheng Pan <[email protected]>
(cherry picked from commit 8bfae02)
Signed-off-by: Cheng Pan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@beryllw beryllw

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[KYUUBI #6079] Web UI support Basic authN beryllw/incubator-kyuubi
3 participants
@beryllw @pan3793 @zwangsheng