Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] The CONNECTION level FlinkSQL engine will not exit immediately after there is no opened session. #6130

Closed
3 of 4 tasks
wForget opened this issue Mar 5, 2024 · 0 comments
Closed
3 of 4 tasks

[Bug] The CONNECTION level FlinkSQL engine will not exit immediately after there is no opened session. #6130

wForget opened this issue Mar 5, 2024 · 0 comments
Assignees
@wForget
Labels
kind:bug This is a clearly a bug priority:major

Comments

@wForget
Copy link
Member

wForget commented Mar 5, 2024

Code of Conduct

Search before asking

  • I have searched in the issues and found no similar issues.

Describe the bug

The CONNECTION level FlinkSQL engine will not exit immediately after there is no opened session.

Affects Version(s)

1.8.0/master

Kyuubi Server Log Output

No response

Kyuubi Engine Log Output

No response

Kyuubi Server Configurations

No response

Kyuubi Engine Configurations

No response

Additional context

No response

Are you willing to submit PR?

  • Yes. I would be willing to submit a PR with guidance from the Kyuubi community to fix.
  • No. I cannot submit a PR at this time.
@wForget wForget added kind:bug This is a clearly a bug priority:major labels Mar 5, 2024
@wForget wForget mentioned this issue Mar 5, 2024
Closed
4 tasks
@wForget wForget self-assigned this Mar 5, 2024
@pan3793 pan3793 closed this as completed in 9c18a7e Mar 8, 2024
pan3793 pushed a commit that referenced this issue Mar 8, 2024
@wForget @pan3793
[KYUUBI #6130] Stop engine immediately after close session for `CONNE…
b66b8d1 
…CTION` level FlinkSQLEngine

# 🔍 Description
## Issue References 🔗

This pull request fixes #6130

## Describe Your Solution 🔧

Stop engine immediately after close session for `CONNECTION` level FlinkSQLEngine

## Types of changes 🔖

- [X] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)

## Test Plan 🧪

#### Behavior Without This Pull Request ⚰️

#### Behavior With This Pull Request 🎉

#### Related Unit Tests

---

# Checklist 📝

- [x] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html)

**Be nice. Be informative.**

Closes #6132 from wForget/KYUUBI-6130.

Closes #6130

033c0ff [wforget] assert exception
c0ce68e [wforget] debug
07e0320 [wforget] add test
a3c4ae3 [wforget] [KYUUBI-6130] Stop engine immediately after close session for `CONNECTION` level FlinkSQLEngine

Authored-by: wforget <[email protected]>
Signed-off-by: Cheng Pan <[email protected]>
(cherry picked from commit 9c18a7e)
Signed-off-by: Cheng Pan <[email protected]>
zhouyifan279 pushed a commit to zhouyifan279/kyuubi that referenced this issue Mar 11, 2024
@wForget @zhouyifan279
[KYUUBI apache#6130] Stop engine immediately after close session for …
844e4a3 
…`CONNECTION` level FlinkSQLEngine

# 🔍 Description
## Issue References 🔗

This pull request fixes apache#6130

## Describe Your Solution 🔧

Stop engine immediately after close session for `CONNECTION` level FlinkSQLEngine

## Types of changes 🔖

- [X] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)

## Test Plan 🧪

#### Behavior Without This Pull Request ⚰️

#### Behavior With This Pull Request 🎉

#### Related Unit Tests

---

# Checklist 📝

- [x] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html)

**Be nice. Be informative.**

Closes apache#6132 from wForget/KYUUBI-6130.

Closes apache#6130

033c0ff [wforget] assert exception
c0ce68e [wforget] debug
07e0320 [wforget] add test
a3c4ae3 [wforget] [KYUUBI-6130] Stop engine immediately after close session for `CONNECTION` level FlinkSQLEngine

Authored-by: wforget <[email protected]>
Signed-off-by: Cheng Pan <[email protected]>
zhaohehuhu pushed a commit to zhaohehuhu/incubator-kyuubi that referenced this issue Mar 21, 2024
@wForget @zhaohehuhu
[KYUUBI apache#6130] Stop engine immediately after close session for …
7c15693 
…`CONNECTION` level FlinkSQLEngine

# 🔍 Description
## Issue References 🔗

This pull request fixes apache#6130

## Describe Your Solution 🔧

Stop engine immediately after close session for `CONNECTION` level FlinkSQLEngine

## Types of changes 🔖

- [X] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)

## Test Plan 🧪

#### Behavior Without This Pull Request ⚰️

#### Behavior With This Pull Request 🎉

#### Related Unit Tests

---

# Checklist 📝

- [x] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html)

**Be nice. Be informative.**

Closes apache#6132 from wForget/KYUUBI-6130.

Closes apache#6130

033c0ff [wforget] assert exception
c0ce68e [wforget] debug
07e0320 [wforget] add test
a3c4ae3 [wforget] [KYUUBI-6130] Stop engine immediately after close session for `CONNECTION` level FlinkSQLEngine

Authored-by: wforget <[email protected]>
Signed-off-by: Cheng Pan <[email protected]>
beryllw pushed a commit to beryllw/incubator-kyuubi that referenced this issue Jun 7, 2024
@wForget
[KYUUBI apache#6130] Stop engine immediately after close session for …
e539e70 
…`CONNECTION` level FlinkSQLEngine

# 🔍 Description
## Issue References 🔗

This pull request fixes apache#6130

## Describe Your Solution 🔧

Stop engine immediately after close session for `CONNECTION` level FlinkSQLEngine

## Types of changes 🔖

- [X] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)

## Test Plan 🧪

#### Behavior Without This Pull Request ⚰️

#### Behavior With This Pull Request 🎉

#### Related Unit Tests

---

# Checklist 📝

- [x] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html)

**Be nice. Be informative.**

Closes apache#6132 from wForget/KYUUBI-6130.

Closes apache#6130

033c0ff [wforget] assert exception
c0ce68e [wforget] debug
07e0320 [wforget] add test
a3c4ae3 [wforget] [KYUUBI-6130] Stop engine immediately after close session for `CONNECTION` level FlinkSQLEngine

Authored-by: wforget <[email protected]>
Signed-off-by: Cheng Pan <[email protected]>

(cherry picked from commit 9c18a7e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wForget wForget

Labels
kind:bug This is a clearly a bug priority:major
Projects
None yet
Milestone
No milestone
1 participant
@wForget