[KYUUBI #5253] Upgrade testcontainers-scala from 0.40.12 to 0.41.0 #5254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pan3793
pushed a commit
that referenced
this pull request
Sep 5, 2023
### _Why are the changes needed?_ close #5253 ### _How was this patch tested?_ - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [ ] Add screenshots for manual tests if appropriate - [ ] [Run test](https://kyuubi.readthedocs.io/en/master/contributing/code/testing.html#running-tests) locally before make a pull request ### _Was this patch authored or co-authored using generative AI tooling?_ NO Closes #5254 from lsm1/branch-kyuubi-5253. Closes #5253 b5c4076 [senmiaoliu] bump testcontainers 0.41.0 Authored-by: senmiaoliu <[email protected]> Signed-off-by: Cheng Pan <[email protected]> (cherry picked from commit 6158599) Signed-off-by: Cheng Pan <[email protected]>
|
Thanks, merged to master/1.8 |
|
Sorry, reverted because of breaking changes. |
bowenliang123
approved these changes
Sep 6, 2023
pan3793
approved these changes
Sep 6, 2023
pan3793
pushed a commit
that referenced
this pull request
Sep 6, 2023
### _Why are the changes needed?_ close #5253 ### _How was this patch tested?_ - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [ ] Add screenshots for manual tests if appropriate - [ ] [Run test](https://kyuubi.readthedocs.io/en/master/contributing/code/testing.html#running-tests) locally before make a pull request ### _Was this patch authored or co-authored using generative AI tooling?_ NO Closes #5254 from lsm1/branch-kyuubi-5253. Closes #5253 b5c4076 [senmiaoliu] bump testcontainers 0.41.0 Authored-by: senmiaoliu <[email protected]> Signed-off-by: Cheng Pan <[email protected]> (cherry picked from commit 6158599) Signed-off-by: Cheng Pan <[email protected]>
pan3793
pushed a commit
that referenced
this pull request
Sep 6, 2023
### _Why are the changes needed?_ close #5253 ### _How was this patch tested?_ - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [ ] Add screenshots for manual tests if appropriate - [ ] [Run test](https://kyuubi.readthedocs.io/en/master/contributing/code/testing.html#running-tests) locally before make a pull request ### _Was this patch authored or co-authored using generative AI tooling?_ NO Closes #5254 from lsm1/branch-kyuubi-5253. Closes #5253 b5c4076 [senmiaoliu] bump testcontainers 0.41.0 Authored-by: senmiaoliu <[email protected]> Signed-off-by: Cheng Pan <[email protected]> (cherry picked from commit 6158599) Signed-off-by: Cheng Pan <[email protected]>
|
It seems to be some problems, my pr is exclusion org.testcontainers from jetcd-launcher in kyuubi-server pom,but in master branch the change appear in the parent pom, it caused CI failed |
|
Why exclusion does not work on parent pom? |
|
#5258 is opened to recover CI. We do exclusion in the parent pom for consistency, except for Hive. |
ok, I see |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
close #5253
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before make a pull request
Was this patch authored or co-authored using generative AI tooling?
NO