Fix UuidPatternConverter javadoc/adoc #3768
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove javadoc incorrectly copied from SequencePatternConverter. Add javadoc for UuidPatternConverter based on the pattern-layout.adoc manual page.
vy
requested changes
Jun 20, 2025
There was a problem hiding this comment.
@julianladisch, thanks so much for these valuable corrections! 💯
Would you also mind updating pattern-layout.adoc too, please?
log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/UuidPatternConverter.java
Outdated
Show resolved
Hide resolved
log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/UuidPatternConverter.java
Outdated
Show resolved
Hide resolved
log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/UuidPatternConverter.java
Outdated
Show resolved
Hide resolved
log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/UuidPatternConverter.java
Outdated
Show resolved
Hide resolved
vy
added
documentation
…/UuidPatternConverter.java Co-authored-by: Volkan Yazıcı <[email protected]>
…/UuidPatternConverter.java Co-authored-by: Volkan Yazıcı <[email protected]>
…/UuidPatternConverter.java Co-authored-by: Volkan Yazıcı <[email protected]>
…/UuidPatternConverter.java Co-authored-by: Volkan Yazıcı <[email protected]>
julianladisch
changed the title
vy
approved these changes
Jun 27, 2025
|
@julianladisch, thanks so much for the kind help. It should be merged once CI passes. |
Generated by gradle/develocity-actions |
vy
reviewed
Jun 27, 2025
log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/UuidPatternConverter.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove javadoc incorrectly copied from SequencePatternConverter.
Add javadoc for UuidPatternConverter based on the pattern-layout.adoc manual page.
Add details to the UuidPatternConverter section in pattern-layout.adoc.
Checklist
Before we can review and merge your changes, please go through the checklist below. If you're still working on some items, feel free to submit your pull request as a draft—our CI will help guide you through the remaining steps.
✅ Required checks
License: I confirm that my changes are submitted under the Apache License, Version 2.0.
Commit signatures: All commits are signed and verifiable. (See GitHub Docs on Commit Signature Verification).
Code formatting: The code is formatted according to the project’s style guide.
How to check and fix formatting
./mvnw spotless:check./mvnw spotless:applySee the build instructions for details.
Build & Test: I verified that the project builds and all unit tests pass.
How to build the project
Run:
./mvnw verifySee the build instructions for details.
🧪 Tests (select one)
📝 Changelog (select one)
src/changelog/.2.x.x. (See Changelog Entry File Guide).