Refactor Faiss-based vector format for easier backport #14934
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor classes of the Faiss-based vector format to simplify backport to 10.x
FaissLibrary
interfaceFaissNativeWrapper
(and useinvokeExact
for faster calls!)FaissLibraryNativeImpl
class implementingFaissLibrary
withFaissNativeWrapper
under the hoodFaissLibraryNativeImpl
fromFaissLibrary
at runtimeFaissNativeWrapper
andFaissLibraryNativeImpl
(as marked by TODOs in build: enable more of javac 24's lints, fix some issues #14907), which can independently be moved into thejava21/
directory for an easier backport (see comments in Backport Faiss-based vector format to 10.x #14843), while theFaissKnnVectors{Format/Reader/Writer}
can stay as-is!