Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review GetHashCode for possible overflows #1065

Closed
paulirwin opened this issue Dec 13, 2024 · 0 comments · Fixed by #1068
Closed

Review GetHashCode for possible overflows #1065

paulirwin opened this issue Dec 13, 2024 · 0 comments · Fixed by #1068
Labels
is:task A chore to be done pri:normal
Milestone
4.8.0-beta00018

Comments

@paulirwin
Copy link
Contributor

We should review GetHashCode to determine if we should be using unchecked to avoid overflow exceptions.

Let's open a new issue to review and use unchecked on each GetHashCode() method where it would make a difference.

Originally posted by @NightOwl888 in #1056 (comment)
@paulirwin paulirwin mentioned this issue Dec 13, 2024
Merged
4 tasks
@paulirwin paulirwin added this to the 4.8.0-beta00018 milestone Dec 14, 2024
@paulirwin paulirwin added is:task A chore to be done pri:normal labels Dec 18, 2024
paulirwin added a commit to paulirwin/lucene.net that referenced this issue Dec 18, 2024
@paulirwin
SWEEP: Add unchecked to GetHashCode, apache#1065
06c77cc
@paulirwin paulirwin mentioned this issue Dec 18, 2024
Merged
4 tasks
NightOwl888 pushed a commit that referenced this issue Dec 19, 2024
@paulirwin
SWEEP: Add unchecked to GetHashCode, #1065 (#1068)
a739a80 
* SWEEP: Add unchecked to GetHashCode, #1065

* Remove redundant unchecked operators
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
is:task A chore to be done pri:normal
Projects
None yet
Milestone
4.8.0-beta00018
Development

Successfully merging a pull request may close this issue.

SWEEP: Add unchecked to GetHashCode, #1065 paulirwin/lucene.net
1 participant
@paulirwin