Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused private/internal types and members #669

Open
nikcio opened this issue Oct 15, 2022 · 1 comment
Open

Remove unused private/internal types and members #669

nikcio opened this issue Oct 15, 2022 · 1 comment
Labels
good-first-issue Good for newcomers hacktoberfest-accepted is:enhancement New feature or request pri:normal up-for-grabs This issue is open to be worked on by anyone
Milestone
4.8.0-beta00018

Comments

@nikcio
Copy link
Contributor

nikcio commented Oct 15, 2022 •
edited
Loading

Mentioned in #648

Specific issue: https://sonarcloud.io/project/issues?issues=AYPAuNd5hbfJOGLOoZ8u&open=AYPAuNd5hbfJOGLOoZ8u&id=nikcio_lucenenet (Solved)

This can be removed and replaced with a comment // LUCENENET specific - removed FSTEntry because it is not in use.

Similar issues found: https://sonarcloud.io/project/issues?resolved=false&rules=csharpsquid%3AS1144&id=apache_lucenenet
@NightOwl888 NightOwl888 added up-for-grabs This issue is open to be worked on by anyone good-first-issue Good for newcomers is:enhancement New feature or request hacktoberfest-accepted labels Oct 15, 2022
@rclabo rclabo self-assigned this Oct 21, 2022
@rclabo rclabo mentioned this issue Oct 21, 2022
Merged
@paulirwin paulirwin added this to the 4.8.0 milestone Oct 28, 2024
@paulirwin paulirwin modified the milestones: 4.8.0, 4.8.0-beta00018 Nov 18, 2024
@paulirwin paulirwin changed the title Remove the unused internal class 'FSTEntry' Remove unused private/internal types and members Dec 6, 2024
@paulirwin
Copy link
Contributor

There are many remaining unused private methods and properties at the sonar link in the original description. I've updated the title to indicate that those should be removed as well.

@NightOwl888 let me know if you disagree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good-first-issue Good for newcomers hacktoberfest-accepted is:enhancement New feature or request pri:normal up-for-grabs This issue is open to be worked on by anyone
Projects
None yet
Milestone
4.8.0-beta00018
Development

No branches or pull requests
4 participants
@NightOwl888 @paulirwin @rclabo @nikcio