Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ShingleFilter produces invalid queries #943

Open
1 task done
tohidemyname opened this issue Jun 4, 2024 · 2 comments
Open
1 task done

ShingleFilter produces invalid queries #943

tohidemyname opened this issue Jun 4, 2024 · 2 comments

Comments

@tohidemyname
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Describe the bug

ShingleFilter uses the position length attribute of the token stream to encode the number of terms they put in a single token.
This breaks the query parsing because it creates disconnected graphs.

Expected Behavior

No response

Steps To Reproduce

I will implement a test case to show the bug.

Exceptions (if any)

No response

Lucene.NET Version

No response

.NET Version

8.0.300

Operating System

win 10

Anything else?

No response

tohidemyname pushed a commit to tohidemyname/lucenenet that referenced this issue Jun 4, 2024
@tohidemyname
Copy link
Contributor Author

My patch is submitted: #944

tohidemyname pushed a commit to tohidemyname/lucenenet that referenced this issue Jun 5, 2024
tohidemyname pushed a commit to tohidemyname/lucenenet that referenced this issue Jun 5, 2024
@tohidemyname
Copy link
Contributor Author

Sorry. I am unfamiliar with submitting pull requests. I may wrongly close my pull request. I have submitted a new pull request.
#946

@paulirwin paulirwin added this to the 4.8.0-beta00018 milestone Oct 28, 2024
paulirwin pushed a commit to tohidemyname/lucenenet that referenced this issue Oct 29, 2024
paulirwin added a commit that referenced this issue Nov 4, 2024
* ShingleFilter produces invalid queries
#943

* Add LUCENENET-specific backport comment, fix test name, fix test position and code style

---------

Co-authored-by: tohidemyname <tohidemyname>
Co-authored-by: Paul Irwin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants