nimble/host: Add Initial Unicast implementation #1622
Conversation
KKopyscinski
force-pushed
the
leaudio_iso_initial
branch
from
31fabbd to
dd97201
Compare
KKopyscinski
force-pushed
the
leaudio_iso_initial
branch
4 times, most recently
from
f7e5a28 to
c9df490
Compare
KKopyscinski
force-pushed
the
leaudio_iso_initial
branch
2 times, most recently
from
9b2461d to
777e183
Compare
KKopyscinski
force-pushed
the
leaudio_iso_initial
branch
2 times, most recently
from
38f8717 to
71ffab7
Compare
| static int | ||
| ble_hs_rx_iso(struct os_mbuf *om, void *arg) | ||
| { | ||
| #if MYNEWT_VAL(BLE_ISO) |
There was a problem hiding this comment.
@andrzej-kaczmarek please check if MYNEWT_VAL name is OK for you
nimble/controller/src/ble_ll_hci.c
Outdated
| @@ -1276,9 +1276,6 @@ ble_ll_hci_le_cmd_proc(const uint8_t *cmdbuf, uint8_t len, uint16_t ocf, | |||
| break; | |||
| #endif /* BLE_LL_ISO_BROADCASTER */ | |||
| #if MYNEWT_VAL(BLE_LL_CFG_FEAT_LL_ISO) | |||
| case BLE_HCI_OCF_LE_READ_ISO_TX_SYNC: | |||
There was a problem hiding this comment.
this is not implemented in original patch, but is implemented in upstream, here: https://github.com/apache/mynewt-nimble/pull/1622/files/71ffab70ca8289793dbfba862938865a75e97568#diff-b69485df5b88a9df6b5628d97643bd77c54001a4027fc3a0384ae016308dd2f4R1308
basically case is duplicated, once as empty boilerplate and second time with actual code
There was a problem hiding this comment.
if we are having duplicated code already merged - please create separate patch for that.
There was a problem hiding this comment.
this will be moved to seperate patch
| mask |= 0x0000000040000000; | ||
| } | ||
|
|
||
| #if MYNEWT_VAL(BLE_ISO) |
There was a problem hiding this comment.
wondering if we should not have two MYNEWT_VALs - one for Broadcast and one for unicast.
@andrzej-kaczmarek any opinion on that?
| * Enable the following LE events: | ||
| * 0x0000000040000000 LE Request Peer SCA Complete event | ||
| */ | ||
| mask |= 0x0000000040000000; |
There was a problem hiding this comment.
this could be separate patch I guess.
| @@ -102,6 +102,10 @@ syscfg.defs: | |||
| value: 0 | |||
| restrictions: | |||
| - 'BLE_ISO if 1' | |||
| BLE_ISO_LOOPBACK: | |||
There was a problem hiding this comment.
this should not be part of this patch. Maybe later on could be added
| @@ -173,6 +178,48 @@ static int s_ble_hci_device = MYNEWT_VAL(BLE_SOCK_LINUX_DEV); | |||
| static int s_ble_hci_device = 0; | |||
| #endif | |||
|
|
|||
| static int | |||
| ble_hci_sock_iso_tx(struct os_mbuf *om) | |||
There was a problem hiding this comment.
wondering if this transport patch could be in separate patch ?
| @@ -497,10 +507,21 @@ syscfg.defs: | |||
| description: 'Minimum level for the BLE EATT log.' | |||
| value: 1 | |||
|
|
|||
| BLE_HS_LEAUDIO_MOD: | |||
There was a problem hiding this comment.
this LOGs could be separate patch. I think it was used in the Application using ISO right?
There was a problem hiding this comment.
Maybe? I don't see this LOG being used anywhere, so I can remove it
nimble/host/src/ble_iso.c
Outdated
| } | ||
|
|
||
| static void | ||
| ble_iso_sent_big_complete_event(struct ble_iso_group *big, |
There was a problem hiding this comment.
I think we should split this patch for Broadcast and Unicast.
KKopyscinski
force-pushed
the
leaudio_iso_initial
branch
2 times, most recently
from
cd31421 to
af6937b
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
KKopyscinski
changed the title
KKopyscinski
force-pushed
the
leaudio_iso_initial
branch
2 times, most recently
from
9c29813 to
64622e9
Compare
KKopyscinski
force-pushed
the
leaudio_iso_initial
branch
from
64622e9 to
7ff9e81
Compare
This commit provides initial implementation ofunicast ISO in host.
KKopyscinski
force-pushed
the
leaudio_iso_initial
branch
from
7ff9e81 to
20679e0
Compare
This commit provides initial implementation of ISO in host.