nimble/host: NULL assign data pointer after free #1792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sjanc Please take a look and review |
sjanc
reviewed
Jun 4, 2024
|
Hi @sjanc , So data here is the pointer which is passed as parameter to ble_gap_ext_adv_set_data. Apps like bleprph, create a data pointer, allocate it and then invoke ble_gap_ext_adv_set_data . Since the function does have the code to free the "os_mbuf *data" , this change is to also NULL initialize it. |
|
you set local variable literally just before returning from function. that is just pointless. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After buffer is freed, explicitly NULL assign the pointer to data.