bug: `Error::with_temporary` is private, but required to implement `HttpFetch`

[bonsairobo]

Describe the bug

I am trying to impl HttpFetch for a newtype wrapper around reqwest_middleware::ClientWithMiddleware by copying the code from impl HttpFetch for reqwest::Client. This almost works except we can't call Error::with_temporary because it's private.

Steps to Reproduce

Try calling Error::with_temporary.

Expected Behavior

Error::with_temporary can be called.

Additional Context

No response

Are you willing to submit a PR to fix this bug?

• Yes, I would like to submit a PR.

[dosubot]

Hi @bonsairobo! I'm Dosu and I’m helping the opendal team.

The reason you can't call Error::with_temporary is that it's private, which restricts its use to within its defining module. However, you don't necessarily need it to implement HttpFetch for your newtype. The codebase uses public error construction methods like Error::new with chaining methods such as with_operation, with_context, and set_source to build errors for HTTP operations. This pattern is public and should work for your use case as well—see this example from the repo.

If you want to proceed with a PR, you could either propose making with_temporary public (if you have a strong use case), or adapt your implementation to use the public error constructors and chaining methods, which is the current recommended approach.

To reply, just mention @dosu.

---

^{How did I do? Good | Irrelevant | Incorrect | Verbose | Hallucination | Report 🐛 | Other}    

[bonsairobo]

@dosu

This pattern is public and should work for your use case as well

None of the public methods on Error allow me to set the inner ErrorStatus field, which is required to get the correct behavior from Error::is_temporary. I assume there is a good reason that this behavior is necessary in impl HttpFetch for reqwest::Client, which is why I'm trying to copy it.

[dosubot]

You're right—there's currently no public way to set the inner ErrorStatus or mark an error as temporary, which is necessary for correct behavior from Error::is_temporary. The official HttpFetch impl for reqwest::Client uses the private Error::with_temporary, and there aren't any public alternatives or patterns in the codebase for this.

If you want to proceed, proposing a PR to make Error::with_temporary public or to add a public API for marking errors as temporary would be a reasonable next step. Let me know if you'd like help drafting that!

To reply, just mention @dosu.

---

^{How did I do? Good | Irrelevant | Incorrect | Verbose | Hallucination | Report 🐛 | Other}    

[Xuanwo]

I'm open to make it public. Do you have interest in doing this? @bonsairobo

[bonsairobo]

@Xuanwo Yea I think I'll have time today

[bonsairobo]

Looks like this was solved by #6513