Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow actions to accept db protocol as parameter #177

Open
daisy-ycguo opened this issue Aug 23, 2018 · 4 comments
Open

Allow actions to accept db protocol as parameter #177

daisy-ycguo opened this issue Aug 23, 2018 · 4 comments

Comments

@daisy-ycguo
Copy link
Member

daisy-ycguo commented Aug 23, 2018

In the database-actions, https is hard coded in the source code. (see a sample here) So all database-actions cannot support databases which accept http connection only.

Adding a new parameter protocol to database-actions can resolve this issue.

@daisy-ycguo
Copy link
Member Author

While, I also notice this package cannot manage those Cloudant db which doesn't support https connection. It has been hard coded in the action source files to use "https".
We should fix this too.

@jasonpet
Copy link
Contributor

jasonpet commented Aug 23, 2018

I do not follow your original comment about changesWebAction. I agree with you about the hardcoded files for the other actions. I use couchdb with http for the changes action and it works fine.

@daisy-ycguo
Copy link
Member Author

daisy-ycguo commented Aug 24, 2018

@jasonpet, you are right. My original comment was wrong. changesWebAction works fine for couchdb with http. I will change the title and description to highlight the hardcoded files.

BTW, /whisk.system/cloudant/changes can accept parameter protocol, while other actions cannot. We should document this.

@daisy-ycguo daisy-ycguo changed the title Allow to config db protocol while installing package Allow actions to accept db protocol as parameter Aug 24, 2018
@jasonpet
Copy link
Contributor

@daisy-ycguo - please feel free to submit a PR to update the documentation or a fix for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants