Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup unused members #1518

Open
pavibhai opened this issue May 24, 2023 · 4 comments
Open

Cleanup unused members #1518

pavibhai opened this issue May 24, 2023 · 4 comments

Comments

@pavibhai
Copy link
Contributor

pavibhai commented May 24, 2023

Looking through the ORC code we seem to have some members that are not used from within the ORC project. It is likely that some of these are being used externally.

We will have to go through this list and decide on the following:

  • Which ones can be safely deleted as they are not being used anywhere?
  • Which ones shall have to be migrated as extension/injection and see if we can move this functionality into the consuming project
  • For ones that will still remain within ORC we should add unit tests

Here are some examples that come readily to mind. We will build a comprehensive list of these as part of this task.

  • PhysicalFSWriter.getOptions
  • RecordReaderImpl.encodeTranslatedSargColumn
  • RecordReaderImpl.mapTranslatedSargColumns
  • RecordReaderUtils.readRanges
  • SchemaEvolution.getPositionalColumns
  • SerializationUtils.parseDateFromString
@pavibhai pavibhai added this to the 2.0.0 milestone May 24, 2023
@dongjoon-hyun
Copy link
Member

Thank you, @pavibhai !

@dongjoon-hyun
Copy link
Member

BTW, I want to propose to broaden the definition of Unused.

At least, we need to check a subset of the popular downstream projects. For example, the following.

  • Apache Spark
  • Apache Arrow
  • Apache Hive
  • Apache Flink

@paliwalashish
Copy link
Contributor

Started looking into it. After running the inspection in Intellij, it gave 184 warning. Perhaps a lot of noise in here.
Trying to see what would be the best way to create the list and validate against the repo's mentioned above.

Suggestions?

@dongjoon-hyun
Copy link
Member

This is removed from Milestone 2.0.0.

@dongjoon-hyun dongjoon-hyun removed this from the 2.0.0 milestone Dec 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants