Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spec: Introduce unittests and integration tests #26

Open
Xuanwo opened this issue Aug 1, 2024 · 7 comments
Open

spec: Introduce unittests and integration tests #26

Xuanwo opened this issue Aug 1, 2024 · 7 comments

Comments

@Xuanwo
Copy link
Member

Xuanwo commented Aug 1, 2024

Our community works hard on implementation specifications. It's time for us to introduce unit tests and integration tests. We need to ensure that we can serialize/deserialize specifications correctly.

@QuakeWang
Copy link
Contributor

I will add the Snapshot test for soon.

@QuakeWang
Copy link
Contributor

The serialize/deserialize in Snapshot has completd by #39. I will add ut for the rest files.

@Xuanwo
Copy link
Member Author

Xuanwo commented Aug 6, 2024

The serialize/deserialize in Snapshot has completd by #39. I will add ut for the rest files.

That would be greatly appreciated.

@QuakeWang
Copy link
Contributor

The following JSON is output by ManifestFileData with Java.

{manifest-eddc1df1-3bfd-4918-bff3-a41560a8d280, 10000, 65, 35, org.apache.paimon.stats.BinaryTableStats@c2774299, 0}

The following JSON is output by ManifestFileData with Rust. In the Rust version has using #[serde(rename = "_FILE_NAME")] for rename the definition.

{"_FILE_NAME":"manifest_file_meta.json","_FILE_SIZE":1024,"_NUM_ADDED_FILES":10,"_NUM_DELETED_FILES":5,"_PARTITION_STATS":{"_MIN_VALUES":[1,2,3],"_MAX_VALUES":[4,5,6],"_NULL_COUNTS":[]},"_SCHEMA_ID":0}

Which one should be used when adding the serialize/deserialize test?

cc @Xuanwo

@Xuanwo
Copy link
Member Author

Xuanwo commented Aug 13, 2024

Does it mean ManifestFileData in java has it's own output format? It doesn't look like a valid JSON to me.

cc @devillove084, would you like to generate some fixture for ManifestFileData too?

@devillove084
Copy link
Contributor

Does it mean ManifestFileData in java has it's own output format? It doesn't look like a valid JSON to me.

cc @devillove084, would you like to generate some fixture for ManifestFileData too?

@Xuanwo No problem, I will mention another ISSUE and related PR in some time later.

@devillove084
Copy link
Contributor

Does it mean ManifestFileData in java has it's own output format? It doesn't look like a valid JSON to me.
cc @devillove084, would you like to generate some fixture for ManifestFileData too?

@Xuanwo No problem, I will mention another ISSUE and related PR in some time later.

link #54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants