Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(spec): implement data field #21

Merged
merged 1 commit into from
Aug 4, 2024
Merged

feat(spec): implement data field #21

merged 1 commit into from
Aug 4, 2024

Conversation

devillove084
Copy link
Contributor

@devillove084 devillove084 commented Jul 25, 2024 •
edited
Loading

This PR will implement DataField.
close #22

@Xuanwo
Copy link
Member

Xuanwo commented Aug 1, 2024 •
edited
Loading

Thanks a lot! We're planning to refactor the data type first, so this PR may need to wait a bit until we figure out the correct approach. Sorry for any inconvenience.

@devillove084
Copy link
Contributor Author

I noticed that the new data type has been merged, so I rebased onto the latest main branch and ensured that all local tests and clippy checks passed. When you have time, could you please approve the changes and review the code? If there are any omissions or inaccuracies, please point them out, and I'll address them promptly. @Xuanwo

@Xuanwo Xuanwo mentioned this pull request Aug 2, 2024
Closed
Xuanwo
Xuanwo reviewed Aug 2, 2024
View reviewed changes
crates/paimon/src/spec/schema.rs Outdated Show resolved Hide resolved
crates/paimon/src/spec/schema.rs Outdated Show resolved Hide resolved
crates/paimon/src/spec/schema.rs Outdated Show resolved Hide resolved
crates/paimon/src/spec/schema.rs Outdated Show resolved Hide resolved
crates/paimon/src/spec/schema.rs Outdated Show resolved Hide resolved
crates/paimon/src/spec/schema.rs Outdated Show resolved Hide resolved
crates/paimon/src/spec/schema.rs Outdated Show resolved Hide resolved
@Xuanwo
Copy link
Member

Xuanwo commented Aug 3, 2024

Hi, this PR includes some unrelated changes that make it difficult to review. Could you please address this?

Xuanwo
Xuanwo reviewed Aug 3, 2024
View reviewed changes
crates/paimon/src/spec/schema.rs Outdated Show resolved Hide resolved
crates/paimon/src/spec/schema.rs Outdated Show resolved Hide resolved
Xuanwo
Xuanwo approved these changes Aug 3, 2024
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@JingsongLi
Copy link
Contributor

Test failed, @devillove084 can you fix the test?

@devillove084
Copy link
Contributor Author

Test failed, @devillove084 can you fix the test?

Okay, I will repair it later

@devillove084
Copy link
Contributor Author

I've already checked and fixed the issues with the tests. Whenever you have time, could you please help approve it? Thank you very much! @JingsongLi

JingsongLi
JingsongLi approved these changes Aug 4, 2024
View reviewed changes
Copy link
Contributor

@JingsongLi JingsongLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@JingsongLi JingsongLi merged commit 8a9a316 into apache:main Aug 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JingsongLi JingsongLi JingsongLi approved these changes

@Xuanwo Xuanwo Xuanwo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

spec: Implement Data Field
3 participants
@devillove084 @Xuanwo @JingsongLi