Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove main branch protect #8

Merged
merged 1 commit into from
Jul 8, 2024
Merged

Conversation

JingsongLi
Copy link
Contributor

Every commit will send a email to private:
Protected Branches for paimon-rust.git has been updated

Maybe we don't need to use protect branch?

@@ -31,16 +31,12 @@ github:
enabled_merge_buttons:
squash: true
merge: false
rebase: false
rebase: true
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can use rebase to some PRs collaborations with multiple people.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this.

@Xuanwo
Copy link
Member

Xuanwo commented Jul 8, 2024

Every commit will send a email to private:
Protected Branches for paimon-rust.git has been updated

I've never heard of this. It might be because the project is relatively new and the same PR base doesn't have an asf.yml file yet. I believe this issue will resolve itself in the future.

@Xuanwo
Copy link
Member

Xuanwo commented Jul 8, 2024

I've never heard of this. It might be because the project is relatively new and the same PR base doesn't have an asf.yml file yet. I believe this issue will resolve itself in the future.

Confirmed with @JingsongLi. I don't know what happened. Let's disable it for now.

Copy link
Member

@SteNicholas SteNicholas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@SteNicholas SteNicholas merged commit e5f8e2b into apache:main Jul 8, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants