Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add empty commit options to support some situation #4422

Open
2 tasks done
zlzhang0122 opened this issue Oct 31, 2024 · 0 comments
Open
2 tasks done

[Feature] Add empty commit options to support some situation #4422

zlzhang0122 opened this issue Oct 31, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@zlzhang0122
Copy link

Search before asking

  • I searched in the issues and found nothing similar.

Motivation

In some special cases, there maybe exists a situation that the CommitMessage is not empty but all the table files in it are empty, and if the job failover because of conflict, the job will be unrecoverable since the value of numCommitted will be greater than 1, so the job will failover infinite and can't be restore.

The exception is "This exception is intentionally thrown after committing the restored checkpoints. By restarting the job we hope that writers can start writing based on these new commits".

Solution

We can add an core options such as 'commit.ignore-empty-commit' to support commit an empty snapshot, and then we can restore the job normally.

Anything else?

No response

Are you willing to submit a PR?

  • I'm willing to submit a PR!
@zlzhang0122 zlzhang0122 added the enhancement New feature or request label Oct 31, 2024
@zlzhang0122 zlzhang0122 changed the title [Feature] Add empty commit options to support some special situation [Feature] Add empty commit options to support some situation Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant