[improve] extract field in value that already contains in key #1825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JingsongLi
reviewed
Aug 15, 2023
| @@ -164,11 +165,14 @@ private Builder( | |||
| public KeyValueFileWriterFactory build( | |||
| BinaryRow partition, int bucket, CoreOptions options) { | |||
| RowType fileRowType = KeyValue.schema(keyType, valueType); | |||
| RowType storageRowType = RowTypeUtils.toStorageRowType(fileRowType); | |||
There was a problem hiding this comment.
Here we need an option, by default, we can use old style row type. Because we need to be as compatible with old readers as possible.
Then wait for 1-2 versions, and switch to the default mode to thin mode.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The key-value storage (in primary-key table) are redundant.
Now, the format of a row is: _KEY_a, _KEY_b, _FIELD_SEQUENCE, _ROW_KIND, a, b, c, d, e, f, g
The column "a" and "b" have double restored. A optimization is:
While reading, we find the
a,bfrom key and fill them to value.This PR is not complete, unit tests and compatibility test will need to be done.