[flink] Avoid deprecated SetupableStreamOperator #4591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
yunfengzhou-hub
force-pushed
the
2.0-preview-setup
branch
2 times, most recently
from
e4444d5
to
2f0b1b5
Compare
JingsongLi
reviewed
Nov 26, 2024
| @@ -54,7 +53,6 @@ public abstract class PrepareCommitOperator<IN, OUT> extends AbstractStreamOpera | |||
|
|
|||
| public PrepareCommitOperator(Options options) { | |||
| this.options = options; | |||
| setChainingStrategy(ChainingStrategy.ALWAYS); | |||
There was a problem hiding this comment.
The chainingStrategy in AbstractStreamOperator is HEAD by default.
There was a problem hiding this comment.
AbstractStreamOperator#getChainingStrategy is used in SimpleOperatorFactory when the operator is subclass of SetupableStreamOperator. When PrepareCommitOperator does not inherit from SetupableStreamOperator, SimpleOperatorFactory will use ChainingStrategy.DEFAULT_CHAINING_STRATEGY = ALWAYS.
There was a problem hiding this comment.
Can you add tests for this? To check chainable.
JingsongLi
reviewed
Nov 26, 2024
.../paimon-flink-cdc/src/main/java/org/apache/paimon/flink/sink/cdc/FlinkCdcMultiTableSink.java
Show resolved
Hide resolved
yunfengzhou-hub
force-pushed
the
2.0-preview-setup
branch
from
2f0b1b5
to
0333afe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: #4442
This PR fixes deprecated usage on Flink's
SetupableStreamOperator, and replaces the function withStreamOperatorFactory.Tests
Existing test cases are used to verify this change.
API and Format
This change does not affect API or storage format.
Documentation
This change does not affect introduce a new feature.