Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumps Thrift version to 0.9.3 #303

Closed
asfimport opened this issue Sep 9, 2015 · 6 comments
Closed

Bumps Thrift version to 0.9.3 #303

asfimport opened this issue Sep 9, 2015 · 6 comments

Comments

@asfimport
Copy link
Collaborator

asfimport commented Sep 9, 2015

Thrift 0.7.0 is too old a version, and it doesn't compile on Mac. Would be nice to bump Thrift version.

Reporter: Cheng Lian / @liancheng
Assignee: Julien Le Dem / @julienledem

Related issues:

PRs and other links:

Note: This issue was originally created as PARQUET-371. Please see the migration documentation for further details.

@asfimport
Copy link
Collaborator Author

Ryan Blue / @rdblue:
I believe that the underlying thrift format is compatible across versions, so this should work. But, I'd rather update everything to thrift 9 instead of worrying about compatibility between the two. I don't want to have a case where we add a class that causes issues when it uses the wrong libthrift version and have that possibly sneak into a release.

@asfimport
Copy link
Collaborator Author

Cheng Lian / @liancheng:
That would be even nicer. I'll update my PR.

@asfimport
Copy link
Collaborator Author

Ryan Blue / @rdblue:
@isnotinvain, is this okay to merge? I think it's a good idea to update our thrift version, but I think you guys are the heaviest users. We'll need to check that elephantbird doesn't pull in 0.7.0 also.

@asfimport
Copy link
Collaborator Author

Ryan Blue / @rdblue:
We just talked about this in the Parquet sync and think it is a good idea. I'm marking this for inclusion in parquet-format 2.4.0. Thanks, Cheng!

@asfimport
Copy link
Collaborator Author

Ryan Blue / @rdblue:
I'm removing this as a blocker for the 1.9.0 release. This is a format change so we should release parquet-format 2.4.0 to pull it into a Parquet MR release.

@asfimport
Copy link
Collaborator Author

Ryan Blue / @rdblue:
This PR was merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant