From 66e56fc90986cbd932bafc3bded5dd8fcf7395a1 Mon Sep 17 00:00:00 2001 From: Gidon Gershinsky Date: Mon, 23 Sep 2024 13:03:31 +0300 Subject: [PATCH 1/2] clarify rg ordinal in readers --- Encryption.md | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/Encryption.md b/Encryption.md index 008519b28..669195ae3 100644 --- a/Encryption.md +++ b/Encryption.md @@ -356,6 +356,11 @@ struct RowGroup { } ``` +The integrity of this field is protected by footer (FileMetaData) authenticated encryption. Therefore, +the reader implementations can use either a local row group counter (ordinal) or the `RowGroup.ordinal` +field as an input to AAD suffix calculation. The latter option can be helpful when different reader +threads process different row groups in the same parquet file. + A `crypto_metadata` field is set in each ColumnChunk in the encrypted columns. ColumnCryptoMetaData is a union - the actual structure is chosen depending on whether the column is encrypted with the footer encryption key, or with a column-specific key. For the latter, a key metadata can be specified. From 3690b033a63c94669228ea360a5e3b85031650cc Mon Sep 17 00:00:00 2001 From: Gidon Gershinsky Date: Tue, 24 Sep 2024 10:13:00 +0300 Subject: [PATCH 2/2] nit: sentence structure --- Encryption.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Encryption.md b/Encryption.md index 669195ae3..180b9aa6b 100644 --- a/Encryption.md +++ b/Encryption.md @@ -356,7 +356,7 @@ struct RowGroup { } ``` -The integrity of this field is protected by footer (FileMetaData) authenticated encryption. Therefore, +The integrity of this field is protected by authenticated encryption of the footer (FileMetaData). Therefore, the reader implementations can use either a local row group counter (ordinal) or the `RowGroup.ordinal` field as an input to AAD suffix calculation. The latter option can be helpful when different reader threads process different row groups in the same parquet file.