Make incubator notice optional #116
Conversation
| } | ||
| import autoImport._ | ||
|
|
||
| val version = ParadoxPlugin.readProperty("pekko-paradox.properties", "pekko.paradox.version") | ||
|
|
||
| val incubatorNoticeText = |
There was a problem hiding this comment.
I put the text into a publicly accessible val so that if we set the default value of pekkoParadoxIncubatorNotice to None (which we will do in the future at some point) if for some reason someone wants to access the original text they can
mdedetrich
requested review from
samueleresca,
pjfanning,
raboof,
He-Pin,
nvollmar,
Roiocam,
jxnu-liguobin,
gmethvin and
seglo
| <p> | ||
| $page.properties.("incubator.notice")$ | ||
| </p> | ||
| $ endif $ |
There was a problem hiding this comment.
could we include this in the if?
<div class="logo">
<a href="https://incubator.apache.org/" one-link-mark="yes">
<img src="$page.properties.("assets.hostname")$assets/images/apache-incubator.svg" alt="Apache Incubator logo" id="incubator__logo">
</a>
</div>
we don't want the incubator logo after we leave the Incubator.
There was a problem hiding this comment.
Ah right, will do
mdedetrich
force-pushed
the
make-incubator-notice-optional
branch
from
6fc4a56 to
112661f
Compare
|
This is what it looks like now which is a lot better
Merging |
|
I have no problem with the implementation of this PR, Thanks @mdedetrich, but I have some suggestions for improving the final render: Can we change the layout of the footer? I think the styles of https://fury.apache.org/ and https://answer.apache.org/ are easier to migrate to the Apache Top Level Project, which will not lead to a large area of white space, in the end, it will be looks like: https://storm.apache.org/ and https://opendal.apache.org/ |
I also agree with this approach. |
Resolves: #115
Trying this with pekko core, this is what it looks like with this change (there should be no difference in rendered text)
And when setting
pekkoParadoxIncubatorNoticetoNone