Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add assets.hostname property in header and nav partials #127

Merged
merged 3 commits into from
Mar 4, 2024

Conversation

samueleresca
Copy link
Member

@samueleresca samueleresca commented Mar 4, 2024

Related to apache/pekko-site#95 suppress #126

There are link in the paradox theme where we don't prepend the assets.hostname property. This cause some 404 on the assets of https://pekko.apache.org. For example:

Test locally

To test this locally:

  1. Build and run sbt publishLocal
  2. Specify the snapshot version in a downstream projects (e.g.: incubator-pekko-http, incubator-pekko-grpc)
  3. Check the target/paradox/site/main/ folder

Copy link
Contributor

@pjfanning pjfanning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

If we get a new snapshot, I can try it out locally.

@samueleresca
Copy link
Member Author

lgtm

If we get a new snapshot, I can try it out locally.

Proceeding by merging and we can try this in the downstream modules. I verified the changes locally by publishing it locally. Note that the resulting html should be published in the target/paradox/site/main/ folder

@samueleresca samueleresca merged commit 1389267 into apache:main Mar 4, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants