Add test coverage report/badges #23
Labels
enhancement
New feature or request
Comments
eric-maynard
pushed a commit
to eric-maynard/polaris
that referenced
this issue
Jul 30, 2024
This does the following: - Adds a broker to manage `PINNACLE_SERVICE` tokens - Adds a broker to manage `PINNACLE_PRINCIPAL` tokens - Adds a broker to interact with the `oauth/token-info` endpoint in GS - Extends the CallCtx plumbing - Adds a HTTPUtility to make calls to GS with Notably missing: - End-to-end tests (I wrote this all on a plane) - Error handling There are extenstive tests
eric-maynard
pushed a commit
to eric-maynard/polaris
that referenced
this issue
Jul 30, 2024
…g names (apache#23) SNOW-1549292 Adding annotation and enforcing size limits for Principal, Role, Catalog and Catalog Role names. Also blocking "SYSTEM$" prefix from being used in names. Adding case-insensitive regex rule to block "SYSTEM$" ## Pre-review checklist - [ ] I attest that this change meets the bar for low risk without security requirements as defined in the [Accelerated Risk Assessment Criteria](https://developer-handbook.m1.us-west-2.aws.app.snowflake.com/docs/reference/security-review/accelerated-risk-assessment/#eligibility) and I have taken the [Risk Assessment Training in Workday](https://wd5.myworkday.com/snowflake/learning/course/6c613806284a1001f111fedf3e4e0000). - Checking this checkbox is mandatory if using the [Accelerated Risk Assessment](https://developer-handbook.m1.us-west-2.aws.app.snowflake.com/docs/reference/security-review/accelerated-risk-assessment/) to risk assess the changes in this Pull Request. - If this change does not meet the bar for low risk without security requirements (as confirmed by the peer reviewers of this pull request) then a [formal Risk Assessment](https://developer-handbook.m1.us-west-2.aws.app.snowflake.com/docs/reference/security-review/risk-assessment/) must be completed. Please note that a formal Risk Assessment will require you to spend extra time performing a security review for this change. Please account for this extra time earlier rather than later to avoid unnecessary delays in the release process. - [x] This change has code coverage for the new code added
eric-maynard
pushed a commit
to eric-maynard/polaris
that referenced
this issue
Jul 30, 2024
85e69a3 Add ascii art banner after initialization. (apache#45) 398a264 Add issue + PR templates (apache#27) 2607c97 Retain original copyright in `gradlew` (apache#43) bb8dcf5 Simplify spotless-java expression (apache#24) 6f5bda0 Gradle wrapper - download and verify (apache#32) 7640ec8 No copyright in PR template (apache#33) b939de0 Upgrade to Gradle 8.9 (apache#29) 32b9520 Upgrade to Jackson 2.17.2 (apache#30) 875b8fc Set project name in IDE (apache#23) fa430e8 Prominently warn for Java version < 21 (apache#22) a9c1807 Add Apache license header (apache#19) bfc111d Add some more exclusions to `.gitignore` (apache#20) d9abad8 Suppress unchecked cast warning in DefaultConfigurationStore (apache#18) 7cae6f4 Add base skeleton with updated LICENSE and NOTICE file (apache#8) 4988075 Fix typo in the quickstart docs. (apache#17) 1c4455f Bump gradle/actions from 3.4.2 to 3.5.0 (apache#14) 76fd0f4 Merge Polaris catalog code (#1) REVERT: e8e08d6 Merge remote-tracking branch 'managed-polaris-local/polaris-oss-export' into mcollado-polaris-merge REVERT: 842b08d Made regtest resources configurable REVERT: cad1390 Merge branch 'managed-polaris' into mcollado-polaris-import REVERT: 136f67b SNOW-1543690 Make credentialRotationRequired optional when creating a principal (apache#5) REVERT: 1552b35 Reorganized repository and split Snowflake and OSS Polaris projects with distinct builds (apache#268) REVERT: 3063229 Add brief description to README REVERT: bcc8f65 Initial commit REVERT: 6fa40a9 Merge branch 'main' of github.com:snowflakedb/pinnacle into dhuo-merge-pinnacle-main REVERT: 747cf3e SNOW-1528940 Fix usability issues related to the pentest of invalid role ARN (apache#279) REVERT: 0325090 Merge remote-tracking branch 'pinnacle/main' into mcollado-merge-pinnacle REVERT: 01ffd22 Remove the "required" annotation for remoteUrl in ExternalCatalog. (apache#280) REVERT: 6a3de99 Merge remote-tracking branch 'pinnacle/main' REVERT: 1bbd9b1 Minor fixups to preserve semantics of some of the helper scripts after the restructure. (apache#278) REVERT: 2186b72 Adding bootstrap action for self hosted Polaris (apache#277) REVERT: 8f9639d Update model validation to use jakarta.validation annotations (apache#276) REVERT: a80ba68 Update repository references to managed-polaris REVERT: 6736d60 Improve error message for invalid json and distinguish from invalid values (apache#274) REVERT: 92bb3a4 Extended gradle format in root project to apply to oss (apache#273) REVERT: a3f049c Fix json error messages to return clearer validation causes (apache#272) REVERT: a4aecf4 Reorganized repository and split Snowflake and OSS Polaris projects with distinct builds (apache#268) git-subtree-dir: polaris git-subtree-split: 85e69a3007fb89c0aeff7b9aec348538abad3dd1
kevinjqliu
pushed a commit
to kevinjqliu/polaris-catalog
that referenced
this issue
Jul 31, 2024
Sets the project name to `Polaris <version>` for IntelliJ. It _should_ do the same for Eclipse (not tested). Co-authored-by: Anna Filippova <[email protected]> Co-authored-by: JB Onofré <[email protected]>
|
@collado-mike there's a badge in #180 for the state of CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
We should publish badges for the state of the build
Describe the solution you'd like
Badges on the front page of the repo
The text was updated successfully, but these errors were encountered: