Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUILD] Change repositories mode when using gradle init scripts #265

Open
anuragmantri opened this issue Sep 5, 2024 · 2 comments
Open
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@anuragmantri
Copy link

anuragmantri commented Sep 5, 2024

Polaris uses RepositoriesMode.FAIL_ON_PROJECT_REPOS setting for dependency management. For companies using gradle init scripts with internal repository declarations, this will fail to build with below error

Build was configured to prefer settings repositories over project repositories but repository 'maven' was added by initialization script '/Users/anurag/.gradle/init.gradle' 

Should we remove this mode or set it to PREFER_SETTINGS instead?

What are your thoughts @flyrain @aihuaxu ?

@anuragmantri anuragmantri added the enhancement New feature or request label Sep 5, 2024
@flyrain
Copy link
Contributor

flyrain commented Sep 5, 2024

I'm OK with that, as it will make it easy for companies to integrate with internal libs. Feel free to file an PR. Also, this property is introduced by #53, cc @snazy for that.

@snazy
Copy link
Member

snazy commented Sep 9, 2024

I'm okay to remove the setting (use the default).

@flyrain flyrain added the good first issue Good for newcomers label Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants