Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] Reusable integration tests #524

Open
dimas-b opened this issue Dec 10, 2024 · 4 comments
Open

[FEATURE REQUEST] Reusable integration tests #524

dimas-b opened this issue Dec 10, 2024 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@dimas-b
Copy link
Contributor

dimas-b commented Dec 10, 2024

Is your feature request related to a problem? Please describe.

Currently integration tests use TestEnvironmentExtension that is intended to provide multiple execution environments, but at the same time depend on DropwizardExtensionsSupport that automatically starts a local DW server.

Describe the solution you'd like

  • Sharable suite of tests that can be executed against different Polaris servers.
  • Polaris Server lifecycle delegated to the test environment.
  • CI continues to use Dropwizard for integration tests, but in a "backbox" manner (tweaking only via standard config options).

Describe alternatives you've considered

No response

Additional context

No response

@dimas-b dimas-b added the enhancement New feature or request label Dec 10, 2024
@dimas-b
Copy link
Contributor Author

dimas-b commented Dec 10, 2024

I'm working on PR for this issue ⌛

@collado-mike
Copy link
Contributor

@andrew4699 has done some work here - it would be good if he can also help define requirements

@dimas-b
Copy link
Contributor Author

dimas-b commented Dec 10, 2024

I put my notes above. We also have a Zulip thread on this.

@andrew4699
Copy link
Contributor

This sounds great. Today you can jump through a series of hoops and run tests against any Polaris server but it's wasteful (due to always spinning up a DW instance) and not intuitive (only 1 test class supported/distinction between local DW and remote is unclear).

I'm happy to help with implementation once things are less busy. The implementation may also look a bit different in Quarkus vs DW.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants