Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NOTICE + LICENSE* as static resources to distributables #557

Closed
snazy opened this issue Dec 14, 2024 · 3 comments · Fixed by #495 or #591
Closed

Add NOTICE + LICENSE* as static resources to distributables #557

snazy opened this issue Dec 14, 2024 · 3 comments · Fixed by #495 or #591
Assignees
Labels
bug Something isn't working

Comments

@snazy
Copy link
Member

snazy commented Dec 14, 2024

Describe the bug

The NOTICE + LICENSE* files should be included in executable artifacts of distributions, so the contents of these files can be

  • printed to the console in CLI applications
  • returned as static web resources

I.e. those resources need to be programmatically accessible.

@snazy snazy added the bug Something isn't working label Dec 14, 2024
@jbonofre
Copy link
Member

Not the LICENSE from source distribution. It's already done in my PR

@jbonofre jbonofre self-assigned this Dec 15, 2024
@jbonofre jbonofre linked a pull request Dec 15, 2024 that will close this issue
@snazy
Copy link
Member Author

snazy commented Dec 16, 2024

Maybe I wasn't clear in the description, but this issue is about having those resources available programmatically and as static web resources, while #495 just adds these files to the zip/tar/etc

snazy added a commit to snazy/polaris that referenced this issue Dec 16, 2024
Containing a properties file and a utility class to retrieve the Polaris version, plus `NOTICE` and `LICENSE*` resources being programmatically accessible, in Quarkus implicitly as static web resources, for example `http://127.0.0.1:19120/apache-polaris/NOTICE.txt`.

Fixes apache#557
@jbonofre
Copy link
Member

Ahh git it. I thought you mean adding the files in the archive. It makes sense.

snazy added a commit to snazy/polaris that referenced this issue Dec 26, 2024
Containing a properties file and a utility class to retrieve the Polaris version, plus `NOTICE` and `LICENSE*` resources being programmatically accessible, in Quarkus implicitly as static web resources, for example `http://127.0.0.1:19120/apache-polaris/NOTICE.txt`.

Fixes apache#557
snazy added a commit to snazy/polaris that referenced this issue Dec 26, 2024
Containing a properties file and a utility class to retrieve the Polaris version, plus `NOTICE` and `LICENSE*` resources being programmatically accessible, in Quarkus implicitly as static web resources, for example `http://127.0.0.1:19120/apache-polaris/NOTICE.txt`.

Fixes apache#557
snazy added a commit to snazy/polaris that referenced this issue Dec 26, 2024
Containing a properties file and a utility class to retrieve the Polaris version, plus `NOTICE` and `LICENSE*` resources being programmatically accessible, in Quarkus implicitly as static web resources, for example `http://127.0.0.1:19120/apache-polaris/NOTICE.txt`.

Fixes apache#557
snazy added a commit to snazy/polaris that referenced this issue Dec 26, 2024
Containing a properties file and a utility class to retrieve the Polaris version, plus `NOTICE` and `LICENSE*` resources being programmatically accessible, in Quarkus implicitly as static web resources, for example `http://127.0.0.1:19120/apache-polaris/NOTICE.txt`.

Fixes apache#557
snazy added a commit to snazy/polaris that referenced this issue Dec 26, 2024
Containing a properties file and a utility class to retrieve the Polaris version, plus `NOTICE` and `LICENSE*` resources being programmatically accessible, in Quarkus implicitly as static web resources, for example `http://127.0.0.1:19120/apache-polaris/NOTICE.txt`.

Fixes apache#557
snazy added a commit to snazy/polaris that referenced this issue Dec 26, 2024
Containing a properties file and a utility class to retrieve the Polaris version, plus `NOTICE` and `LICENSE*` resources being programmatically accessible, in Quarkus implicitly as static web resources, for example `http://127.0.0.1:19120/apache-polaris/NOTICE.txt`.

Fixes apache#557
snazy added a commit to snazy/polaris that referenced this issue Dec 26, 2024
Utility artifact that provides static resources containing the version and NOTICE + LICENSE* files, which can be directly served by Quarkus as static web resources, for example `http://127.0.0.1:19120/apache-polaris/NOTICE.txt`.

Utility class that provides above mentioned resources programmatically, plus information for release-builds.

Fixes apache#557
snazy added a commit to snazy/polaris that referenced this issue Dec 26, 2024
Utility artifact that provides static resources containing the version and NOTICE + LICENSE* files, which can be directly served by Quarkus as static web resources, for example `http://127.0.0.1:19120/apache-polaris/NOTICE.txt`.

Utility class that provides above mentioned resources programmatically, plus information for release-builds like the Git tag, Git commit ID, build system.

Fixes apache#557
snazy added a commit that referenced this issue Dec 26, 2024
Utility artifact that provides static resources containing the version and NOTICE + LICENSE* files, which can be directly served by Quarkus as static web resources, for example `http://127.0.0.1:19120/apache-polaris/NOTICE.txt`.

Utility class that provides above mentioned resources programmatically, plus information for release-builds like the Git tag, Git commit ID, build system.

Fixes #557
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants