From 6cd2b3c3f8e175727b4bb80ea4e73377dada68b9 Mon Sep 17 00:00:00 2001 From: Yuya Ebihara Date: Sat, 24 Aug 2024 11:35:56 +0900 Subject: [PATCH 1/3] Enable ErrorProne FallThrough --- build-logic/src/main/kotlin/polaris-java.gradle.kts | 1 + .../org/apache/polaris/service/catalog/BasePolarisCatalog.java | 2 ++ 2 files changed, 3 insertions(+) diff --git a/build-logic/src/main/kotlin/polaris-java.gradle.kts b/build-logic/src/main/kotlin/polaris-java.gradle.kts index 4a91766fa..02b80eb03 100644 --- a/build-logic/src/main/kotlin/polaris-java.gradle.kts +++ b/build-logic/src/main/kotlin/polaris-java.gradle.kts @@ -36,6 +36,7 @@ tasks.withType(JavaCompile::class.java).configureEach { options.errorprone.disableWarningsInGeneratedCode = true options.errorprone.error( "DefaultCharset", + "FallThrough", "MissingOverride", "StringCaseLocaleUsage", ) diff --git a/polaris-service/src/main/java/org/apache/polaris/service/catalog/BasePolarisCatalog.java b/polaris-service/src/main/java/org/apache/polaris/service/catalog/BasePolarisCatalog.java index 8d8d1e969..2f79ed4d7 100644 --- a/polaris-service/src/main/java/org/apache/polaris/service/catalog/BasePolarisCatalog.java +++ b/polaris-service/src/main/java/org/apache/polaris/service/catalog/BasePolarisCatalog.java @@ -1587,6 +1587,8 @@ private void renameTableLike( throw new AlreadyExistsException( "Cannot rename %s to %s. View already exists", from, to); } + throw new IllegalStateException( + String.format("Unexpected entity type '%s'", existingEntitySubType)); } case PolarisMetaStoreManager.ReturnStatus.ENTITY_NOT_FOUND: From 1a54e9fcce82024d7805b1880f05da2b55b4ec04 Mon Sep 17 00:00:00 2001 From: Yuya Ebihara Date: Sat, 24 Aug 2024 11:37:25 +0900 Subject: [PATCH 2/3] Enable ErrorProne MissingCasesInEnumSwitch --- build-logic/src/main/kotlin/polaris-java.gradle.kts | 1 + 1 file changed, 1 insertion(+) diff --git a/build-logic/src/main/kotlin/polaris-java.gradle.kts b/build-logic/src/main/kotlin/polaris-java.gradle.kts index 02b80eb03..9b99786aa 100644 --- a/build-logic/src/main/kotlin/polaris-java.gradle.kts +++ b/build-logic/src/main/kotlin/polaris-java.gradle.kts @@ -37,6 +37,7 @@ tasks.withType(JavaCompile::class.java).configureEach { options.errorprone.error( "DefaultCharset", "FallThrough", + "MissingCasesInEnumSwitch", "MissingOverride", "StringCaseLocaleUsage", ) From 1dea06d5900c71d76f9812e615da03b2d0639363 Mon Sep 17 00:00:00 2001 From: Yuya Ebihara Date: Sat, 24 Aug 2024 11:40:00 +0900 Subject: [PATCH 3/3] Enable ErrorProne OrphanedFormatString --- build-logic/src/main/kotlin/polaris-java.gradle.kts | 1 + 1 file changed, 1 insertion(+) diff --git a/build-logic/src/main/kotlin/polaris-java.gradle.kts b/build-logic/src/main/kotlin/polaris-java.gradle.kts index 9b99786aa..d0462212a 100644 --- a/build-logic/src/main/kotlin/polaris-java.gradle.kts +++ b/build-logic/src/main/kotlin/polaris-java.gradle.kts @@ -39,6 +39,7 @@ tasks.withType(JavaCompile::class.java).configureEach { "FallThrough", "MissingCasesInEnumSwitch", "MissingOverride", + "OrphanedFormatString", "StringCaseLocaleUsage", ) }