Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect command to generate public key for end-to-end encryption #779

Merged
merged 2 commits into from
Feb 28, 2024
Merged

Fix incorrect command to generate public key for end-to-end encryption #779

merged 2 commits into from
Feb 28, 2024

Conversation

BewareMyPower
Copy link
Contributor

The command in the document does not work for OpenSSL 1.1 or 3.2.

$ openssl rsa -in test_rsa_privkey.pem -pubout -outform pkcs8 -out test_rsa_pubkey.pem
rsa: Bad format "pkcs8"
rsa: Invalid format "pkcs8" for option -outform
rsa: Use -help for summary.
$ openssl --version
OpenSSL 3.2.0 23 Nov 2023 (Library: OpenSSL 3.2.0 23 Nov 2023)
$ /opt/homebrew/opt/[email protected]/bin/openssl rsa -in test_rsa_privkey.pem -pubout -outform pkcs8 -out test_rsa_pubkey2.pem
rsa: Invalid format "pkcs8" for -outform
rsa: Use -help for summary.
$ /opt/homebrew/opt/[email protected]/bin/openssl version
OpenSSL 1.1.1w  11 Sep 2023
  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@github-actions github-actions bot added the doc Improvements or additions to documentation label Feb 5, 2024
tisonkun
tisonkun approved these changes Feb 5, 2024
View reviewed changes
Copy link
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we update this command for other old docs version?

lhotari
lhotari reviewed Feb 5, 2024
View reviewed changes
docs/security-encryption.md Outdated Show resolved Hide resolved
@lhotari
Copy link
Member

lhotari commented Feb 27, 2024

Shall we update this command for other old docs version?

@BewareMyPower Any chance to handle that in this PR?

@BewareMyPower
Copy link
Contributor Author

Sorry I missed the response before, I will update it soon.

@BewareMyPower
Copy link
Contributor Author

@tisonkun @lhotari I updated docs for 3.0.x and 3.1.x as well because I think we won't maintain 2.x anymore. BTW, I reduced the unnecessary changes of the order of command options.

@tisonkun tisonkun merged commit cb0f6fa into main Feb 28, 2024
2 checks passed
@tisonkun tisonkun deleted the bewaremypower/fix-ssl branch February 28, 2024 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tisonkun tisonkun tisonkun approved these changes

@RobertIndie RobertIndie RobertIndie approved these changes

@lhotari lhotari lhotari approved these changes

@Demogorgon314 Demogorgon314 Awaiting requested review from Demogorgon314

@shibd shibd Awaiting requested review from shibd

Assignees
No one assigned
Labels
doc Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BewareMyPower @lhotari @RobertIndie @tisonkun