From eb818a4ced83acca2afda707133163335fb70db9 Mon Sep 17 00:00:00 2001 From: Alvaro <102966649+AlvaroStream@users.noreply.github.com> Date: Fri, 10 May 2024 11:11:14 +0200 Subject: [PATCH 1/2] Add key_shared advice to Cumulative Ack note - As mentioned in apache/pulsar/issues/22691 --- docs/concepts-messaging.md | 2 +- versioned_docs/version-2.11.x/concepts-messaging.md | 2 +- versioned_docs/version-3.0.x/concepts-messaging.md | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/concepts-messaging.md b/docs/concepts-messaging.md index 7647680b27d4..45aace525d2d 100644 --- a/docs/concepts-messaging.md +++ b/docs/concepts-messaging.md @@ -78,7 +78,7 @@ consumer.acknowledgeCumulative(msg); :::note -Cumulative acknowledgment cannot be used in [Shared subscription type](#subscription-types), because Shared subscription type involves multiple consumers which have access to the same subscription. In Shared subscription type, messages are acknowledged individually. +Cumulative acknowledgment cannot be used in [Shared or Key_shared subscription type](#subscription-types), because Shared or Key_Shared subscription type involves multiple consumers which have access to the same subscription. In Shared and Key_Shared subscription types, messages should be acknowledged individually. ::: diff --git a/versioned_docs/version-2.11.x/concepts-messaging.md b/versioned_docs/version-2.11.x/concepts-messaging.md index 01735effb828..aa6e6ee8ccae 100644 --- a/versioned_docs/version-2.11.x/concepts-messaging.md +++ b/versioned_docs/version-2.11.x/concepts-messaging.md @@ -227,7 +227,7 @@ consumer.acknowledgeCumulative(msg); :::note -Cumulative acknowledgment cannot be used in [Shared subscription type](#subscription-types), because Shared subscription type involves multiple consumers which have access to the same subscription. In Shared subscription type, messages are acknowledged individually. +Cumulative acknowledgment cannot be used in [Shared or Key_shared subscription type](#subscription-types), because Shared or Key_Shared subscription type involves multiple consumers which have access to the same subscription. In Shared and Key_Shared subscription types, messages should be acknowledged individually. ::: diff --git a/versioned_docs/version-3.0.x/concepts-messaging.md b/versioned_docs/version-3.0.x/concepts-messaging.md index 7647680b27d4..45aace525d2d 100644 --- a/versioned_docs/version-3.0.x/concepts-messaging.md +++ b/versioned_docs/version-3.0.x/concepts-messaging.md @@ -78,7 +78,7 @@ consumer.acknowledgeCumulative(msg); :::note -Cumulative acknowledgment cannot be used in [Shared subscription type](#subscription-types), because Shared subscription type involves multiple consumers which have access to the same subscription. In Shared subscription type, messages are acknowledged individually. +Cumulative acknowledgment cannot be used in [Shared or Key_shared subscription type](#subscription-types), because Shared or Key_Shared subscription type involves multiple consumers which have access to the same subscription. In Shared and Key_Shared subscription types, messages should be acknowledged individually. ::: From c2ba34a457b318825b2e9a23741dec2646d6f982 Mon Sep 17 00:00:00 2001 From: Alvaro <102966649+AlvaroStream@users.noreply.github.com> Date: Fri, 10 May 2024 15:08:00 +0200 Subject: [PATCH 2/2] Missed version 3.2.0 --- versioned_docs/version-3.2.x/concepts-messaging.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/versioned_docs/version-3.2.x/concepts-messaging.md b/versioned_docs/version-3.2.x/concepts-messaging.md index fd720434dc60..e630fa27f3f2 100644 --- a/versioned_docs/version-3.2.x/concepts-messaging.md +++ b/versioned_docs/version-3.2.x/concepts-messaging.md @@ -84,7 +84,7 @@ consumer.acknowledgeCumulative(msg); :::note -Cumulative acknowledgment cannot be used in [Shared subscription type](#subscription-types), because Shared subscription type involves multiple consumers which have access to the same subscription. In Shared subscription type, messages are acknowledged individually. +Cumulative acknowledgment cannot be used in [Shared or Key_shared subscription type](#subscription-types), because Shared or Key_Shared subscription type involves multiple consumers which have access to the same subscription. In Shared subscription type, messages are acknowledged individually. :::