[fix][test] Fix NonDurableSubscriptionTest.testInitReaderAtSpecifiedP… #23293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
summeriiii
force-pushed
the
fix_nondurable_subscription_test
branch
2 times, most recently
from
7ede944
to
a3fb3e2
Compare
|
@poorbarcode PTAL, thx |
summeriiii
force-pushed
the
fix_nondurable_subscription_test
branch
from
a3fb3e2
to
faf1521
Compare
|
@poorbarcode the test failed before and I rebased master, could you help to trigger the workflow? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #23293 +/- ##
============================================
+ Coverage 73.57% 74.35% +0.77%
- Complexity 32624 34428 +1804
============================================
Files 1877 1943 +66
Lines 139502 147045 +7543
Branches 15299 16205 +906
============================================
+ Hits 102638 109334 +6696
- Misses 28908 29281 +373
- Partials 7956 8430 +474
Flags with carried forward coverage won't be shown. Click here to find out more. |
visxu
pushed a commit
to vissxu/pulsar
that referenced
this pull request
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The comments and code are inconsistent in the test
NonDurableSubscriptionTest.testInitReaderAtSpecifiedPosition, some are comments not correct while others are code not correct. This issue was introduced by #21248.Modifications
fix the inconsistent between comments and code in the test
NonDurableSubscriptionTest.testInitReaderAtSpecifiedPositionDocumentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: