-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve][build] Use eclipse-temurin:17 image instead of apt installation #23335
Conversation
…tion Signed-off-by: Zixuan Liu <[email protected]>
/pulsarbot rerun-failure-checks |
Please provide more context in the description. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We shouldn't change the LTS version if there isn't a very strong reason to do so.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking this PR until there's clarification of the necessity of this change.
@lhotari I have updated the PR description, and significantly reducing the image size would be beneficial for version 3.0. |
/pulsarbot rerun-failure-checks |
@nodece There's a high risk that this is a breaking change for many users. If this change is made, there needs to be a PIP. I'll close this PR that it doesn't get accidentially merged without an explicit decision. |
One possible reason why there's such a large difference is caused by the fact that command |
Our private version has already merged this feature, and once there are no issues during testing, I will create a PIP to improve this. |
Motivation
Reduce the docker image size by https://adoptium.net/zh-CN/blog/2021/08/using-jlink-in-dockerfiles/
It was reduced by 320MB.
We already improved the 4.0.0: #22973
Modifications
Documentation
doc
doc-required
doc-not-needed
doc-complete