[fix][broker] Avoid introducing delay when there are delayed messages or marker messages #23343
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
PR #23226 introduced a change to introduce a delay before calling
readMoreEntries
in PersistentDispatcherMultipleConsumers classes when no messages were dispatched.This logic didn't take into account the case when all messages are delayed messages, marker messages or messages from an aborted transaction. In those cases additional delays would be introduced, causing performance regressions.
Modifications
lastNumberOfEntriesProcessed
tracks how many entries were processed by consumers in the lasttrySendMessagesToConsumers
calltrySendMessagesToConsumers
call. Only in those cases should the retry happen after a delay with increasing backoff.Documentation
doc
doc-required
doc-not-needed
doc-complete