Skip to content

Committer Guide

Sijie Guo edited this page Jan 22, 2020 · 3 revisions

This guide is for committers and covers Pulsar's guidelines for reviewing and merging code.

Merge Pull Request

After all the tests pass, there should be a green merge button at the bottom of the pull request. Currently, only the "Squash and merge" option is available in the Pulsar project.

When the committer merges a pull request, please make sure to add necessary labels and milestones to the pull request.

Labels

Make sure that you have added area/ and type/ labels to the pull request. If this pull request is required to be ported to a branch for a minor release, please also add the minor release label release/x.y.z. If the release label doesn't exist, please create one for it.

Milestone

For pull requests that are merged to master, they will be released in the next major release. Please add milestone that represents next major release to the pull request.

Clone this wiki locally